linux-kernel - Re: [PATCH v1 1/2] usb: phy: tegra: use phy type directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509061310.SU5Tf105-lkp@intel.com>
Date: Sat, 6 Sep 2025 13:41:47 +0800
From: kernel test robot <lkp@...el.com>
To: Svyatoslav Ryhel <clamor95@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Dmitry Osipenko <digetx@...il.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-usb@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] usb: phy: tegra: use phy type directly

Hi Svyatoslav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tegra/for-next]
[cannot apply to usb/usb-testing usb/usb-next usb/usb-linus staging/staging-testing staging/staging-next staging/staging-linus linus/master v6.17-rc4 next-20250905]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Svyatoslav-Ryhel/usb-phy-tegra-use-phy-type-directly/20250905-003521
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
patch link:    https://lore.kernel.org/r/20250904163238.238105-2-clamor95%40gmail.com
patch subject: [PATCH v1 1/2] usb: phy: tegra: use phy type directly
config: i386-buildonly-randconfig-006-20250906 (https://download.01.org/0day-ci/archive/20250906/202509061310.SU5Tf105-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250906/202509061310.SU5Tf105-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509061310.SU5Tf105-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/usb/phy/phy-tegra-usb.c:874:2: warning: variable 'err' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
     874 |         default:
         |         ^~~~~~~
   drivers/usb/phy/phy-tegra-usb.c:878:6: note: uninitialized use occurs here
     878 |         if (err)
         |             ^~~
   include/linux/compiler.h:55:47: note: expanded from macro 'if'
      55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
         |                                               ^~~~
   include/linux/compiler.h:57:52: note: expanded from macro '__trace_if_var'
      57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   drivers/usb/phy/phy-tegra-usb.c:860:9: note: initialize the variable 'err' to silence this warning
     860 |         int err;
         |                ^
         |                 = 0
   drivers/usb/phy/phy-tegra-usb.c:905:2: warning: variable 'err' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
     905 |         default:
         |         ^~~~~~~
   drivers/usb/phy/phy-tegra-usb.c:909:6: note: uninitialized use occurs here
     909 |         if (err)
         |             ^~~
   include/linux/compiler.h:55:47: note: expanded from macro 'if'
      55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
         |                                               ^~~~
   include/linux/compiler.h:57:52: note: expanded from macro '__trace_if_var'
      57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   drivers/usb/phy/phy-tegra-usb.c:891:9: note: initialize the variable 'err' to silence this warning
     891 |         int err;
         |                ^
         |                 = 0
   2 warnings generated.


vim +/err +874 drivers/usb/phy/phy-tegra-usb.c

   857	
   858	static int tegra_usb_phy_power_on(struct tegra_usb_phy *phy)
   859	{
   860		int err;
   861	
   862		if (phy->powered_on)
   863			return 0;
   864	
   865		switch (phy->phy_type) {
   866		case USBPHY_INTERFACE_MODE_UTMI:
   867			err = utmi_phy_power_on(phy);
   868			break;
   869	
   870		case USBPHY_INTERFACE_MODE_ULPI:
   871			err = ulpi_phy_power_on(phy);
   872			break;
   873	
 > 874		default:
   875			break;
   876		}
   877	
   878		if (err)
   879			return err;
   880	
   881		phy->powered_on = true;
   882	
   883		/* Let PHY settle down */
   884		usleep_range(2000, 2500);
   885	
   886		return 0;
   887	}
   888	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki