linux-kernel - Re: [PATCH] cdrom: add parentheses around macro arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509061338.yRYn1te8-lkp@intel.com>
Date: Sat, 6 Sep 2025 14:03:43 +0800
From: kernel test robot <lkp@...el.com>
To: Joey Pabalinas <joeypabalinas@...il.com>,
	Phillip Potter <phil@...lpotter.co.uk>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cdrom: add parentheses around macro arguments

Hi Joey,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.17-rc4 next-20250905]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Joey-Pabalinas/cdrom-add-parentheses-around-macro-arguments/20250906-020047
base:   linus/master
patch link:    https://lore.kernel.org/r/13378f5c9cafc29425b6e420cad8b513f4a9f1e1.1757095005.git.joeypabalinas%40gmail.com
patch subject: [PATCH] cdrom: add parentheses around macro arguments
config: sh-randconfig-r071-20250906 (https://download.01.org/0day-ci/archive/20250906/202509061338.yRYn1te8-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250906/202509061338.yRYn1te8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509061338.yRYn1te8-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/cdrom/cdrom.c: In function 'register_cdrom':
>> drivers/cdrom/cdrom.c:413:13: error: expected identifier before '(' token
     413 |  if ((cdo)->(call) == NULL)    \
         |             ^
   drivers/cdrom/cdrom.c:604:2: note: in expansion of macro 'ENSURE'
     604 |  ENSURE(cdo, drive_status, CDC_DRIVE_STATUS);
         |  ^~~~~~
>> drivers/cdrom/cdrom.c:413:13: error: expected identifier before '(' token
     413 |  if ((cdo)->(call) == NULL)    \
         |             ^
   drivers/cdrom/cdrom.c:607:2: note: in expansion of macro 'ENSURE'
     607 |  ENSURE(cdo, tray_move, CDC_CLOSE_TRAY | CDC_OPEN_TRAY);
         |  ^~~~~~
>> drivers/cdrom/cdrom.c:413:13: error: expected identifier before '(' token
     413 |  if ((cdo)->(call) == NULL)    \
         |             ^
   drivers/cdrom/cdrom.c:608:2: note: in expansion of macro 'ENSURE'
     608 |  ENSURE(cdo, lock_door, CDC_LOCK);
         |  ^~~~~~
>> drivers/cdrom/cdrom.c:413:13: error: expected identifier before '(' token
     413 |  if ((cdo)->(call) == NULL)    \
         |             ^
   drivers/cdrom/cdrom.c:609:2: note: in expansion of macro 'ENSURE'
     609 |  ENSURE(cdo, select_speed, CDC_SELECT_SPEED);
         |  ^~~~~~
>> drivers/cdrom/cdrom.c:413:13: error: expected identifier before '(' token
     413 |  if ((cdo)->(call) == NULL)    \
         |             ^
   drivers/cdrom/cdrom.c:610:2: note: in expansion of macro 'ENSURE'
     610 |  ENSURE(cdo, get_last_session, CDC_MULTI_SESSION);
         |  ^~~~~~
>> drivers/cdrom/cdrom.c:413:13: error: expected identifier before '(' token
     413 |  if ((cdo)->(call) == NULL)    \
         |             ^
   drivers/cdrom/cdrom.c:611:2: note: in expansion of macro 'ENSURE'
     611 |  ENSURE(cdo, get_mcn, CDC_MCN);
         |  ^~~~~~
>> drivers/cdrom/cdrom.c:413:13: error: expected identifier before '(' token
     413 |  if ((cdo)->(call) == NULL)    \
         |             ^
   drivers/cdrom/cdrom.c:612:2: note: in expansion of macro 'ENSURE'
     612 |  ENSURE(cdo, reset, CDC_RESET);
         |  ^~~~~~
>> drivers/cdrom/cdrom.c:413:13: error: expected identifier before '(' token
     413 |  if ((cdo)->(call) == NULL)    \
         |             ^
   drivers/cdrom/cdrom.c:613:2: note: in expansion of macro 'ENSURE'
     613 |  ENSURE(cdo, generic_packet, CDC_GENERIC_PACKET);
         |  ^~~~~~


vim +413 drivers/cdrom/cdrom.c

   405	
   406	/* This macro makes sure we don't have to check on cdrom_device_ops
   407	 * existence in the run-time routines below. Change_capability is a
   408	 * hack to have the capability flags defined const, while we can still
   409	 * change it here without gcc complaining at every line.
   410	 */
   411	#define ENSURE(cdo, call, bits)					\
   412	do {								\
 > 413		if ((cdo)->(call) == NULL)				\
   414			WARN_ON_ONCE((cdo)->capability & (bits));	\
   415	} while (0)
   416	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki