linux-kernel - Re: [PATCH v7 1/1] Bluetooth: mediatek: add gpio pin to reset bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509061837.tyzBvcs9-lkp@intel.com>
Date: Sat, 6 Sep 2025 19:04:58 +0800
From: kernel test robot <lkp@...el.com>
To: Zhangchao Zhang <ot_zhangchao.zhang@...iatek.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Luiz Von Dentz <luiz.dentz@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Sean Wang <sean.wang@...iatek.com>,
	Jiande Lu <jiande.lu@...iatek.com>,
	Deren Wu <deren.Wu@...iatek.com>, Chris Lu <chris.lu@...iatek.com>,
	Hao Qin <Hao.qin@...iatek.com>,
	linux-bluetooth <linux-bluetooth@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-mediatek <linux-mediatek@...ts.infradead.org>,
	Zhangchao Zhang <ot_zhangchao.zhang@...iatek.com>
Subject: Re: [PATCH v7 1/1] Bluetooth: mediatek: add gpio pin to reset bt

Hi Zhangchao,

kernel test robot noticed the following build errors:

[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master linus/master v6.17-rc4 next-20250905]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zhangchao-Zhang/Bluetooth-mediatek-add-gpio-pin-to-reset-bt/20250905-164341
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link:    https://lore.kernel.org/r/20250905084059.26959-2-ot_zhangchao.zhang%40mediatek.com
patch subject: [PATCH v7 1/1] Bluetooth: mediatek: add gpio pin to reset bt
config: x86_64-buildonly-randconfig-001-20250906 (https://download.01.org/0day-ci/archive/20250906/202509061837.tyzBvcs9-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250906/202509061837.tyzBvcs9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509061837.tyzBvcs9-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/bluetooth/btmtk.c:370:34: error: incompatible pointer types passing 'struct device_node *' to parameter of type 'struct device *' [-Werror,-Wincompatible-pointer-types]
     370 |         reset_gpio = gpiod_get_optional(hdev->dev.of_node, "reset", GPIOD_OUT_HIGH);
         |                                         ^~~~~~~~~~~~~~~~~
   include/linux/gpio/consumer.h:72:66: note: passing argument to parameter 'dev' here
      72 | struct gpio_desc *__must_check gpiod_get_optional(struct device *dev,
         |                                                                  ^
   1 error generated.


vim +370 drivers/bluetooth/btmtk.c

   363	
   364	static int btmtk_hw_gpio_reset(struct hci_dev *hdev, struct btmtk_data *reset_work)
   365	{
   366		struct gpio_desc *reset_gpio;
   367	
   368		/* Find device node*/
   369		hdev->dev.of_node = of_find_compatible_node(NULL, NULL, "mediatek,mt7925-bluetooth");
 > 370		reset_gpio = gpiod_get_optional(hdev->dev.of_node, "reset", GPIOD_OUT_HIGH);
   371		if (IS_ERR(reset_gpio))
   372			return PTR_ERR(reset_gpio);
   373	
   374		if (!reset_gpio)
   375			return -ENODEV;
   376	
   377		if (test_and_set_bit(BTMTK_HW_RESET_ACTIVE, &reset_work->flags)) {
   378			bt_dev_err(hdev, "last reset failed? Not resetting again");
   379			gpiod_put(reset_gpio);
   380			return -EBUSY;
   381		}
   382		gpiod_set_value_cansleep(reset_gpio, 0);
   383		msleep(100);
   384		gpiod_set_value_cansleep(reset_gpio, 1);
   385		gpiod_put(reset_gpio);
   386		return 0;
   387	}
   388	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki