linux-kernel - Re: [PATCH v3 net 1/2] net: phylink: add lock for serializing concurrent pl->phydev writes with resolver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175712040831.2733722.5895135773021312161.git-patchwork-notify@kernel.org>
Date: Sat, 06 Sep 2025 01:00:08 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
 linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net 1/2] net: phylink: add lock for serializing
 concurrent
 pl->phydev writes with resolver

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu,  4 Sep 2025 15:52:37 +0300 you wrote:
> Currently phylink_resolve() protects itself against concurrent
> phylink_bringup_phy() or phylink_disconnect_phy() calls which modify
> pl->phydev by relying on pl->state_mutex.
> 
> The problem is that in phylink_resolve(), pl->state_mutex is in a lock
> inversion state with pl->phydev->lock. So pl->phydev->lock needs to be
> acquired prior to pl->state_mutex. But that requires dereferencing
> pl->phydev in the first place, and without pl->state_mutex, that is
> racy.
> 
> [...]

Here is the summary with links:
  - [v3,net,1/2] net: phylink: add lock for serializing concurrent pl->phydev writes with resolver
    https://git.kernel.org/netdev/net/c/0ba5b2f2c381
  - [v3,net,2/2] net: phy: transfer phy_config_inband() locking responsibility to phylink
    https://git.kernel.org/netdev/net/c/e2a10daba849

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html