linux-kernel - Re: [PATCH 1/2] ARM: dts: samsung: exynos5250: describe sromc bank memory map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250906143958.GA7600@l14.localdomain>
Date: Sat, 6 Sep 2025 16:39:58 +0200
From: Henrik Grimler <henrik@...mler.se>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Alim Akhtar <alim.akhtar@...sung.com>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: samsung: exynos5250: describe sromc bank
 memory map

Hi Krzysztof,

On Sat, Sep 06, 2025 at 02:24:21PM +0200, Krzysztof Kozlowski wrote:
> On 04/09/2025 08:10, Henrik Grimler wrote:
> > According to public user manual for Exynos 5250 [1], the SROM
> > controller has 4 banks, at same addresses as for example Exynos
> > 5410. Describe the bank memory map of the SoC.
> > 
> > [1] https://web.archive.org/web/20130921194458/http://www.samsung.com/global/business/semiconductor/file/product/Exynos_5_Dual_User_Manaul_Public_REV100-0.pdf
> > 
> > Signed-off-by: Henrik Grimler <henrik@...mler.se>
> > ---
> >  arch/arm/boot/dts/samsung/exynos5250.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/samsung/exynos5250.dtsi b/arch/arm/boot/dts/samsung/exynos5250.dtsi
> > index b9e7c493881804647534b1d7395f6eb62a07fb92..741cc693f5d8f6b33772d7819c965c590571f305 100644
> > --- a/arch/arm/boot/dts/samsung/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/samsung/exynos5250.dtsi
> > @@ -1214,6 +1214,15 @@ &serial_3 {
> >  	dma-names = "rx", "tx";
> >  };
> >  
> > +&sromc {
> > +	#address-cells = <2>;
> > +	#size-cells = <1>;
> > +	ranges = <0 0 0x04000000 0x20000
> 
> 
> These should be separate tupples, so
> 
> <0 0 0x04000000 0x20000>,
> <....>,
> <....>,

Thanks, will send a v2 to fix it, and update exynos5410.dtsi, in a day
or two!

> Best regards,
> Krzysztof

Best regards,
Henrik Grimler