linux-kernel - Re: [RFC PATCH] vfat:avoid unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tencent_663B255BAD2BF224E8B5195BCF1F4A4BEC07@qq.com>
Date: Sat,  6 Sep 2025 23:13:49 +0800
From: zhoumin <teczm@...mail.com>
To: hirofumi@...l.parknet.co.jp
Cc: linux-kernel@...r.kernel.org,
	teczm@...mail.com
Subject: Re: [RFC PATCH] vfat:avoid unnecessary check

Hi Hirofumi

> Hm, IS_FREE() checks 0 and DELETED_FLAG, isn't it?

Yes, you're absolutely right. That was my mistake—sorry about that. Please
disregard that part.

> OK, thanks. I got the reason.

> However I would prefer to keep the current code, for readability and
> future changes, and explicitly check those time flags if there is no
> measurable improvement.

I understand your preference. That said, since fat_truncate_time already checks
the flags and handles them appropriately, I still feel the double-check might be
redundant. That said, I respect your decision and am okay with keeping it as is.

Thanks,

zhoumin