linux-kernel - Re: [PATCH] kprobe_event_gen_test : Fix error handling and resource cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08543dfc-85e3-4f21-bf30-de612a47504e@web.de>
Date: Sat, 6 Sep 2025 17:55:06 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Fidal palamparambil <rootuserhere@...il.com>,
 linux-modules@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Daniel Gomez <da.gomez@...nel.org>,
 Luis Chamberlain <mcgrof@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>,
 Sami Tolvanen <samitolvanen@...gle.com>
Subject: Re: [PATCH] kprobe_event_gen_test : Fix error handling and resource
 cleanup

> This commit addresses several issues …

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n94


…
> +++ b/kernel/trace/kprobe_event_gen_test.c
> @@ -129,6 +129,7 @@ static int __init test_gen_kprobe_cmd(void)
>  					       "gen_kprobe_test");
>  	if (IS_ERR(gen_kprobe_test)) {
>  		ret = PTR_ERR(gen_kprobe_test);
> +		gen_kprobe_test = NULL;

May the repetition be reduced for this assignment statement?


>  		goto delete;

How do you think about to use an additional label?


>  	}
…

Regards,
Markus