linux-kernel - Re: [PATCH] PCI: j721e: Fix incorrect error message in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22e63c06-ec7f-4afe-8fc2-f90d49004ce9@ti.com>
Date: Sat, 6 Sep 2025 07:17:49 +0530
From: s-vadapalli <s-vadapalli@...com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
CC: <vigneshr@...com>, <s-vadapalli@...com>, <lpieralisi@...nel.org>,
        <kwilczynski@...nel.org>, <mani@...nel.org>, <robh@...nel.org>,
        <bhelgaas@...gle.com>, <linux-omap@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: j721e: Fix incorrect error message in probe

On Fri, Sep 05, 2025 at 02:14:34PM -0700, Alok Tiwari wrote:
> The probe function printed "pm_runtime_get_sync failed" when
> j721e_pcie_ctrl_init() returned an error. This is misleading since
> the failure was not from pm_runtime but from the controller init
> routine. Update the error message to correctly reflect the source.
> 
> No functional changes.
> 
> Fixes: f3e25911a430 ("PCI: j721e: Add TI J721E PCIe driver")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
> Not sure if a Fixes tag is required here
> ---
>  drivers/pci/controller/cadence/pci-j721e.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
> index 6c93f39d0288..5e445a7bda33 100644
> --- a/drivers/pci/controller/cadence/pci-j721e.c
> +++ b/drivers/pci/controller/cadence/pci-j721e.c
> @@ -549,7 +549,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
>  
>  	ret = j721e_pcie_ctrl_init(pcie);
>  	if (ret < 0) {
> -		dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n");
> +		dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n");
>  		goto err_get_sync;
>  	}

Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>

Regards,
Siddharth.