[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<TY4PR01MB1443251944E84D91018CFE8DE9802A@TY4PR01MB14432.jpnprd01.prod.outlook.com>
Date: Sun, 7 Sep 2025 02:40:47 +0800
From: Shengyu Qu <wiagn233@...look.com>
To: Bin Du <Bin.Du@....com>, mchehab@...nel.org, hverkuil@...all.nl,
laurent.pinchart+renesas@...asonboard.com, bryan.odonoghue@...aro.org,
sakari.ailus@...ux.intel.com, prabhakar.mahadev-lad.rj@...renesas.com,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
sultan@...neltoast.com
Cc: wiagn233@...look.com, pratap.nirujogi@....com, benjamin.chan@....com,
king.li@....com, gjorgji.rosikopulos@....com, Phil.Jawich@....com,
Dominic.Antony@....com, mario.limonciello@....com, richard.gong@....com,
anson.tsao@....com
Subject: Re: [PATCH v3 0/7] Add AMD ISP4 driver
Hi,
> Changes v2 -> v3:
>
> - All the dependent patches in other modules (drm/amd/amdgpu, platform/x86, pinctrl/amd) merged on upstream mainline kernel (https://github.com/torvalds/linux) v6.17.
> - Removed usage of amdgpu structs in ISP driver. Added helper functions in amdgpu accepting opaque params from ISP driver to allocate and release ISP GART buffers.
> - Moved sensor and MIPI phy control entirely into ISP FW instead of the previous hybrid approach controlling sensor from both FW and x86 (sensor driver).
> - Removed phy configuration and sensor binding as x86 (sensor driver) had relinquished the sensor control for ISP FW. With this approach the driver will be exposed as web camera like interface.
> - New FW with built-in sensor driver is submitted on upstream linux-firmware repo (https://gitlab.com/kernel-firmware/linux-firmware/).
The sensor is MIPI CSI and controlled by I2C, isn't it? Then why we put
all control logic into FW rather than driver? Any existing CSI camera
ISP support implementation are not doing this by FW.
Cheers,
Shengyu
Download attachment "OpenPGP_0xE3520CC91929C8E7.asc" of type "application/pgp-keys" (6869 bytes)
Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)
Powered by blists - more mailing lists