linux-kernel - Re: [PATCH v2] drivers: gpu: drm: msm: registers: improve reproducibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGvJnSiyUJvBPusBZ+mriiP_vRiAgZnTyLSseu8Sdf9PXA@mail.gmail.com>
Date: Sat, 6 Sep 2025 16:24:29 -0700
From: Rob Clark <robdclark@...il.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Viswanath Kraleti <viswanath.kraleti@....qualcomm.com>, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Sean Paul <sean@...rly.run>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Ryan Eatmon <reatmon@...com>, linux-arm-msm@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, Bruce Ashfield <bruce.ashfield@...il.com>
Subject: Re: [PATCH v2] drivers: gpu: drm: msm: registers: improve reproducibility

On Sat, May 24, 2025 at 10:15 AM Dmitry Baryshkov
<dmitry.baryshkov@....qualcomm.com> wrote:
>
> On Sat, May 24, 2025 at 09:25:37PM +0530, Viswanath Kraleti wrote:
> > From: Ryan Eatmon <reatmon@...com>
> >
> > The files generated by gen_header.py capture the source path to the
> > input files and the date.  While that can be informative, it varies
> > based on where and when the kernel was built as the full path is
> > captured.
> >
> > Since all of the files that this tool is run on is under the drivers
> > directory, this modifies the application to strip all of the path before
> > drivers.  Additionally it prints <stripped> instead of the date.
> >
> > Signed-off-by: Ryan Eatmon <reatmon@...com>
> > Signed-off-by: Bruce Ashfield <bruce.ashfield@...il.com>
> > Signed-off-by: Viswanath Kraleti <viswanath.kraleti@....qualcomm.com>
> > ---
> > The files generated by gen_header.py include the source path to the
> > input files and the build date. While this information can be useful,
> > it inadvertently exposes build system configuration details in the
> > binaries. This hinders binary reproducibility, as the output will
> > vary if the build environment changes.
> >
> > This change was originally submitted to the linux-yocto-dev kernel [1]
> > to address binary reproducibility QA errors. However, the fix is generic
> > enough to be applicable to the mainline kernel and would benefit other
> > distributions as well. So proposing it here for broader inclusion.
> >
> > [1] https://git.yoctoproject.org/linux-yocto-dev/commit/?id=f36faf0f9f8d8f5b4c43a68e5c6bd83a62253140
> > ---
> > Changes in v2:
> > - Corrected author id
> > - Link to v1: https://lore.kernel.org/r/20250523-binrep-v1-1-c3a446518847@oss.qualcomm.com
> > ---
> >  drivers/gpu/drm/msm/registers/gen_header.py | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
>
> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>
> Rob, WDYT?

I'm revisiting this one, in the context of trying to re-sync
gen_header.py with mesa.. but it is only changing the contents of
comments, so it's not quite clear to me how this ends up mattering for
binary reproducibility.

That said, since the generated files are no longer checked in to mesa
or the kernel, we could probably just drop all of this if it mattered.

BR,
-R