linux-kernel - Re: [PATCH v11 5/7] samples: rust: Add debugfs sample driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGSQo01He7cNvcOQBxAqLicSjKniSp=97K6GupnxS4B=G9p4rw@mail.gmail.com>
Date: Fri, 5 Sep 2025 20:19:37 -0700
From: Matthew Maurer <mmaurer@...gle.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Sami Tolvanen <samitolvanen@...gle.com>, 
	Timur Tabi <ttabi@...dia.com>, Benno Lossin <lossin@...nel.org>, 
	Dirk Beheme <dirk.behme@...bosch.com>, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v11 5/7] samples: rust: Add debugfs sample driver

On Fri, Sep 5, 2025 at 2:00 AM Danilo Krummrich <dakr@...nel.org> wrote:
>
> On Thu Sep 4, 2025 at 11:13 PM CEST, Matthew Maurer wrote:
> > +kernel::acpi_device_table!(
> > +    ACPI_TABLE,
> > +    MODULE_ACPI_TABLE,
> > +    <RustDebugFs as platform::Driver>::IdInfo,
> > +    [(acpi::DeviceId::new(c_str!("LNUXDEBF")), ())]
>
> This should use "LNUXBEEF", as we explicitly reserved it for sample and test
> code.
>
> I think we could reserve more if we see a benefit, but so far it's only used by
> the platform driver sample, so we should be good.
>
> Either way, no need to resend for this only, it can be fixed up on apply. :)

Ah, thanks, I was unaware that it was specially reserved and so tried
to pick something distinct. You fixing up this and the `OF_ID_TABLE`
on apply SGTM.

>
> > +);
> > +
> > +impl platform::Driver for RustDebugFs {
> > +    type IdInfo = ();
> > +    const OF_ID_TABLE: Option<of::IdTable<Self::IdInfo>> = None;
>
> NIT: This defaults to None, so it can be omitted.
>
> > +    const ACPI_ID_TABLE: Option<acpi::IdTable<Self::IdInfo>> = Some(&ACPI_TABLE);