linux-kernel - Re: [PATCH v2 1/3] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aL1rFVaVCxIVaLWm@quark2.heme.sigxcpu.org>
Date: Sun, 7 Sep 2025 13:23:01 +0200
From: Guido Günther <agx@...xcpu.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
	Jessica Zhang <jessica.zhang@....qualcomm.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	phone-devel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] drm/panel: visionox-rm69299: Fix clock frequency
 for SHIFT6mq

Hi Dmitry,
On Sat, Sep 06, 2025 at 10:08:35PM +0300, Dmitry Baryshkov wrote:
> On Sat, Sep 06, 2025 at 05:17:25PM +0200, Guido Günther wrote:
> > Make the clock frequency match what the sdm845 downstream kernel
> > uses. Otherwise the panel stays black.
> > 
> > Fixes: 783334f366b18 ("drm/panel: visionox-rm69299: support the variant found in the SHIFT6mq")
> > Signed-off-by: Guido Günther <agx@...xcpu.org>
> > Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
> > ---
> >  drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > index 909c280eab1fb408a713d84051a1afbb252c45e8..e65697ce6f51c7d64b786da18cf44b16de5d6919 100644
> > --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > @@ -247,7 +247,7 @@ static const struct drm_display_mode visionox_rm69299_1080x2248_60hz = {
> >  };
> >  
> >  static const struct drm_display_mode visionox_rm69299_1080x2160_60hz = {
> > -	.clock = 158695,
> > +	.clock = 149360,
> 
> clock = (2160 + 8 + 4 + 4) * (1080 + 26 + 2 + 36) * 60 / 1000 ?

IIRC I was asked to use the resulting clock rather then the clock
formula in another driver a while back but I like that variant better
too, will change in v3.

Thanks,
 -- Guido

> 
> >  	.hdisplay = 1080,
> >  	.hsync_start = 1080 + 26,
> >  	.hsync_end = 1080 + 26 + 2,
> > 
> > -- 
> > 2.51.0
> > 
> 
> -- 
> With best wishes
> Dmitry
>