[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250907123310.2209f824@jic23-huawei>
Date: Sun, 7 Sep 2025 12:33:10 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>, Matti Vaittinen
<matti.vaittinen@...rohmeurope.com>, David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>, Andy Shevchenko
<andy@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Linus Walleij
<linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Marcelo
Schmitt <marcelo.schmitt@...log.com>, Javier Carrasco
<javier.carrasco.cruz@...il.com>, Tobias Sperling
<tobias.sperling@...ting.com>, Antoniu Miclaus
<antoniu.miclaus@...log.com>, Trevor Gamblin <tgamblin@...libre.com>,
Esteban Blanc <eblanc@...libre.com>, Ramona Alexandra Nechita
<ramona.nechita@...log.com>, Hans de Goede <hansg@...nel.org>, Herve Codina
<herve.codina@...tlin.com>, Alisa-Dariana Roman <alisadariana@...il.com>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO
On Fri, 5 Sep 2025 10:10:55 +0300
Matti Vaittinen <mazziesaccount@...il.com> wrote:
> On 05/09/2025 09:54, Andy Shevchenko wrote:
> > On Fri, Sep 5, 2025 at 9:42 AM Matti Vaittinen <mazziesaccount@...il.com> wrote:
> >>
> >> The ROHM BD79112 is an ADC/GPIO with 32 channels. The channel inputs can
> >> be used as ADC or GPIO. Using the GPIOs as IRQ sources isn't supported.
> >>
> >> The ADC is 12-bit, supporting input voltages up to 5.7V, and separate I/O
> >> voltage supply. Maximum SPI clock rate is 20 MHz (10 MHz with
> >> daisy-chain configuration) and maximum sampling rate is 1MSPS.
> >>
> >> The IC does also support CRC but it is not implemented in the driver.
> >
> > ...
> >
> >> +config ROHM_BD79112
> >> + tristate "Rohm BD79112 ADC driver"
> >> + depends on I2C && GPIOLIB
> >
> > Still I2C?
>
> Thanks :) I didn't spot this @_@. I just switched the REGMAP_I2C to
> REGMAP_SPI. Will fix.
>
> >
> >> + select REGMAP_SPI
> >> + select IIO_ADC_HELPER
> >> + help
> >> + Say yes here to build support for the ROHM BD79112 ADC. The
> >> + ROHM BD79112 is a 12-bit, 32-channel, SAR ADC, which analog
> >
> > which --> where
>
> I thought which (as a genetive case) would work here just fine?
If you had 'on which' I think it would be fine.
With just 'which' it doesn't work. I'm too lazy to figure out exactly
why though :(
I'd probably make it a separate sentence though. Analog inputs can also
be used for GPIO.
Powered by blists - more mailing lists