linux-kernel - Re: [PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D 3D Magnetic sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250907124952.31809adc@jic23-huawei>
Date: Sun, 7 Sep 2025 12:49:52 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Dixit Parmar <dixitparmar19@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: magnetometer: Infineon TLV493D
 3D Magnetic sensor

On Sun, 7 Sep 2025 16:43:34 +0530
Dixit Parmar <dixitparmar19@...il.com> wrote:

> > Krzysztof gave an RB on version 3.  Please make sure to pick up such tags.
> >  
> Indeed, RB was given by Krzystof on the V3 patch but this patch got
> modified for MAINTAINERS file changes which were not part of V3.
> Considering that I thought it should be removed. I have added this in
> the cover letter change logs as well. Is this correct understanding?

When making small changes like that, it's a judgement call you need to make
on whether they are likely to affect the intent of the tag.

To me that one wasn't something that Krzystof was going care about.

Anyhow it's fine that you looked on it differently.  In cases like
this I'd expect to see a comment under the --- in the patch that a tag
was given but dropped because of xyz reasons.

Keep that in future versions until the tag is given again or other
comment invalidates it.

Jonathan

> > This time I'll apply it by hand if nothing else comes up.  
> Thanks,
> Dixit