linux-kernel - Re: [PATCH v2 1/3] clk: Introduce clk_hw_set_spread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250907130409.GA26925@nxa18884-linux.ap.freescale.net>
Date: Sun, 7 Sep 2025 21:04:09 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Brian Masney <bmasney@...hat.com>
Cc: Peng Fan <peng.fan@....com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>,
	Sudeep Holla <sudeep.holla@....com>,
	Cristian Marussi <cristian.marussi@....com>,
	Marco Felsch <m.felsch@...gutronix.de>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] clk: Introduce clk_hw_set_spread_spectrum

On Tue, Sep 02, 2025 at 06:01:12PM -0400, Brian Masney wrote:
>>   *
>> + * @set_spread_spectrum: Configure the modulation frequency, modulation percentage
>> + *		and method. This callback is optional for clocks that does not
>> + *		support spread spectrum feature or no need to enable this feature.
>> + *		Returns 0 on success, -EERROR otherwise.
>
>I think it would be worthwhile to call out in the kdocs that this helps
>to reduce EMI. How does this sound?
>
>@set_spread_spectrum: Optional callback used to configure the spread
>		spectrum modulation frequency, percentage, and method
>		to reduce EMI by spreading the clock frequency over a
>		wider range.
>		Returns 0 on success, -EERROR otherwise.

This is better. I will update in v3.

Thanks,
Peng

>
>Everything else looks good to me.
>
>Brian
>