linux-kernel - Re: [PATCH] platform/x86: lg-laptop: Fix WMAB call in fan_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN2PR06MB55980FFA32BF5DABCE34333EDC0DA@MN2PR06MB5598.namprd06.prod.outlook.com>
Date: Sat, 6 Sep 2025 22:28:39 -0400
From: Daniel <dany97@...e.ca>
To: ilpo.jarvinen@...ux.intel.com
Cc: dany97@...e.ca, linux-kernel@...r.kernel.org, matan@...alib.org,
 platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] platform/x86: lg-laptop: Fix WMAB call in fan_mode_store

> Is it okay to remove preserving the other bits?

The WMAB call reads only the lower nibble or the upper nibble from the
lowest byte.  Similarly when the fan status is read from WMAB, something
of the form ((x << 4) | x) is always returned.

> Please name these field with defined GENMASK() and then use FIELD_PREP()
> here for both fields.

I don't see why something like that should be necessary, seems overkill,
but if you insist then I'll do it.

I'll try to send another patch sometime soon, I've been very busy.