linux-kernel - Re: [PATCH v3 1/3] dt-bindings: iio: adc: ROHM BD79112 ADC/GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69eb8aaf-2ab4-4e54-89cf-1be51a616258@gmail.com>
Date: Sun, 7 Sep 2025 15:37:39 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Marcelo Schmitt <marcelo.schmitt@...log.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Tobias Sperling <tobias.sperling@...ting.com>,
 Antoniu Miclaus <antoniu.miclaus@...log.com>,
 Trevor Gamblin <tgamblin@...libre.com>, Esteban Blanc <eblanc@...libre.com>,
 Ramona Alexandra Nechita <ramona.nechita@...log.com>,
 Hans de Goede <hansg@...nel.org>, Herve Codina <herve.codina@...tlin.com>,
 Alisa-Dariana Roman <alisadariana@...il.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: iio: adc: ROHM BD79112 ADC/GPIO

On 07/09/2025 14:19, Jonathan Cameron wrote:
> On Fri, 5 Sep 2025 09:42:18 +0300
> Matti Vaittinen <mazziesaccount@...il.com> wrote:
> 
>> The ROHM BD79112 is an ADC/GPIO with 32 channels. The channel inputs can
>> be used as ADC or GPIO. Using the GPIOs as IRQ sources isn't supported.
>>
>> The ADC is 12-bit, supporting input voltages up to 5.7V, and separate I/O
>> voltage supply. Maximum SPI clock rate is 20 MHz (10 MHz with
>> daisy-chain configuration) and maximum sampling rate is 1MSPS.
>>
>> Add a device tree binding document for the ROHM BD79112.
>>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
>> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> Trivial comment below.  If everything else is good on this version
> it isn't worth a respin.
> 
>> +examples:
>> +  - |
>> +    spi {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +        adc: adc@0 {
>> +            compatible = "rohm,bd79112";
>> +            reg = <0x0>;
>> +
>> +            spi-cpha;
>> +            spi-cpol;
>> +
>> +            vdd-supply = <&dummyreg>;
>> +            iovdd-supply = <&dummyreg>;
>> +
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +
>> +            gpio-controller;
>> +            #gpio-cells = <2>;
>> +
>> +            channel@0 {
>> +                reg = <0>;
>> +            };
>> +            channel@1 {
>> +                reg = <1>;
>> +            };
>> +            channel@2 {
>> +                reg = <2>;
>> +            };
>> +            channel@3 {
>> +                reg = <3>;
> Trivial point but I get bored scrolling.
> Would a smaller set of channels allow you to provide same level
> of testing / documentation?

I suppose yes. Trimming this to maybe 3 channels would be just fine. 
I'll re-spin the series anyways so I'll crop this too.

Yours,
	-- Matti