linux-kernel - Re: [PATCH 06/10] iio: accel: BMA220 add LPF cut-off frequency mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250907135004.6c7faba9@jic23-huawei>
Date: Sun, 7 Sep 2025 13:50:04 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Petre Rodan <petre.rodan@...dimension.ro>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH 06/10] iio: accel: BMA220 add LPF cut-off frequency
 mapping

On Fri, 5 Sep 2025 14:59:27 -0500
David Lechner <dlechner@...libre.com> wrote:

> On 9/1/25 2:47 PM, Petre Rodan wrote:
> >  - add mapping for the low pass filter cut-off frequency.
> >  - make valid values visible for both the cut-off frequency and the scale.
> > 
> > Signed-off-by: Petre Rodan <petre.rodan@...dimension.ro>

> > +/*
> > + * Available cut-off frequencies of the low pass filter in Hz.
> > + */
> > +static const int bma220_lpf_3db_freq_hz_table[][2] = {
> > +	[BMA220_COF_1000HZ] = {1000, 0},
> > +	[BMA220_COF_500HZ] = {500, 0},
> > +	[BMA220_COF_250HZ] = {250, 0},
> > +	[BMA220_COF_125HZ] = {125, 0},
> > +	[BMA220_COF_64HZ] = {64, 0},
> > +	[BMA220_COF_32HZ] = {32, 0},  
> 
> If all of these are integer values, why do we need 2-D table?
Style wise, for IIO we are going for 
{ 32, 0 }, 

That is extra spaces.

Mind you that's irrelevant if it's a 1D array ;)