[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250907201421.3612784-1-alok.a.tiwari@oracle.com>
Date: Sun, 7 Sep 2025 13:14:13 -0700
From: Alok Tiwari <alok.a.tiwari@...cle.com>
To: julien.thierry@....com, marc.zyngier@....com, jintack@...columbia.edu,
christoffer.dall@....com, maz@...nel.org, oliver.upton@...ux.dev,
joey.gouly@....com, suzuki.poulose@....com, yuzenghui@...wei.com,
catalin.marinas@....com, will@...nel.org,
linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev
Cc: alok.a.tiwari@...cle.com, linux-kernel@...r.kernel.org
Subject: [PATCH] KVM: arm64: vgic: fix incorrect spinlock API usage
The function vgic_flush_lr_state() was calling _raw_spin_unlock()
instead of the proper raw_spin_unlock().
_raw_spin_unlock() is an internal low-level API and should not
be used directly; using raw_spin_unlock() ensures proper locking
semantics in the vgic code.
This change replaces low-level API usage with the general kernel
spinlock API, avoiding misuse of internal functions and aligning
with kernel locking conventions.
Fixes: 8fa3adb8c6be ("KVM: arm/arm64: vgic: Make vgic_irq->irq_lock a raw_spinlock")
Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
---
arch/arm64/kvm/vgic/vgic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c
index f5148b38120a..c74d6120a12c 100644
--- a/arch/arm64/kvm/vgic/vgic.c
+++ b/arch/arm64/kvm/vgic/vgic.c
@@ -818,7 +818,7 @@ static void vgic_flush_lr_state(struct kvm_vcpu *vcpu)
* the AP list has been sorted already.
*/
if (multi_sgi && irq->priority > prio) {
- _raw_spin_unlock(&irq->irq_lock);
+ raw_spin_unlock(&irq->irq_lock);
break;
}
--
2.50.1
Powered by blists - more mailing lists