[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250907202049.GD19568@pendragon.ideasonboard.com>
Date: Sun, 7 Sep 2025 22:20:49 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Richard Leitner <richard.leitner@...ux.dev>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
Dave Stevenson <dave.stevenson@...pberrypi.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, Hans Verkuil <hverkuil@...nel.org>
Subject: Re: [PATCH v7 08/10] media: i2c: ov9282: add strobe_source v4l2
control
Hi Richard,
Thank you for the patch.
On Mon, Sep 01, 2025 at 05:05:13PM +0200, Richard Leitner wrote:
> Add read-only V4L2_CID_FLASH_STROBE_SOURCE control. Its value is fixed
> to V4L2_FLASH_STROBE_SOURCE_EXTERNAL as the camera sensor triggers the
> strobe based on its register settings.
I don't think you should implement this control in the sensor driver. It
should only be implemented in the flash controller driver to select the
source.
> Signed-off-by: Richard Leitner <richard.leitner@...ux.dev>
> ---
> drivers/media/i2c/ov9282.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
> index c405e3411daf37cf98d5af3535702f8321394af5..9efc82a1929a76c6fb245e7dbfb5276a133d1c5d 100644
> --- a/drivers/media/i2c/ov9282.c
> +++ b/drivers/media/i2c/ov9282.c
> @@ -1368,11 +1368,12 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
> struct v4l2_ctrl_handler *ctrl_hdlr = &ov9282->ctrl_handler;
> const struct ov9282_mode *mode = ov9282->cur_mode;
> struct v4l2_fwnode_device_properties props;
> + struct v4l2_ctrl *ctrl;
> u32 hblank_min;
> u32 lpfr;
> int ret;
>
> - ret = v4l2_ctrl_handler_init(ctrl_hdlr, 12);
> + ret = v4l2_ctrl_handler_init(ctrl_hdlr, 13);
> if (ret)
> return ret;
>
> @@ -1443,6 +1444,14 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
> v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_DURATION,
> 0, 13900, 1, 8);
>
> + ctrl = v4l2_ctrl_new_std_menu(ctrl_hdlr, &ov9282_ctrl_ops,
> + V4L2_CID_FLASH_STROBE_SOURCE,
> + V4L2_FLASH_STROBE_SOURCE_EXTERNAL,
> + ~(1 << V4L2_FLASH_STROBE_SOURCE_EXTERNAL),
> + V4L2_FLASH_STROBE_SOURCE_EXTERNAL);
> + if (ctrl)
> + ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> ret = v4l2_fwnode_device_parse(ov9282->dev, &props);
> if (!ret) {
> /* Failure sets ctrl_hdlr->error, which we check afterwards anyway */
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists