linux-kernel - Re: [PATCH 2/3] hwmon: (sht21) Add devicetree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502a7a9d-3b5d-4bf9-9cd3-fc3d387ebe62@roeck-us.net>
Date: Sun, 7 Sep 2025 15:19:51 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Kurt Borja <kuurtb@...il.com>, Jean Delvare <jdelvare@...e.com>,
 Jonathan Corbet <corbet@....net>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: stable@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 2/3] hwmon: (sht21) Add devicetree support

On 9/7/25 15:06, Kurt Borja wrote:
> Add DT support for sht2x chips.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Kurt Borja <kuurtb@...il.com>
> ---
>   drivers/hwmon/sht21.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/sht21.c b/drivers/hwmon/sht21.c
> index a2748659edc262dac9d87771f849a4fc0a29d981..9813e04f60430f8e60f614d9c68785428978c4a4 100644
> --- a/drivers/hwmon/sht21.c
> +++ b/drivers/hwmon/sht21.c
> @@ -283,8 +283,16 @@ static const struct i2c_device_id sht21_id[] = {
>   };
>   MODULE_DEVICE_TABLE(i2c, sht21_id);
>   
> +static const struct of_device_id sht21_of_match[] = {
> +	{ .compatible = "sensirion,sht2x" },

This should be individual entries, not a placeholder for multiple chips.

> +	{ }
> +};
> +
>   static struct i2c_driver sht21_driver = {
> -	.driver.name = "sht21",
> +	.driver = {
> +		.name = "sht21",
> +		.of_match_table = sht21_of_match,
> +	},
>   	.probe       = sht21_probe,
>   	.id_table    = sht21_id,
>   };
>