linux-kernel - Re: [PATCH] soc: mediatek: use bool as the function return type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1c2721f-fb38-435f-8351-3d28f13ad4ec@gmail.com>
Date: Sun, 7 Sep 2025 10:59:58 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: Xichao Zhao <zhao.xichao@...o.com>,
 angelogioacchino.delregno@...labora.com
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: mediatek: use bool as the function return type



On 11/08/2025 05:45, Xichao Zhao wrote:
> The function only returns true and false, and the places using the
> function also expect a bool return type. Therefore, the function's
> return type is changed from int to bool.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>   drivers/soc/mediatek/mtk-devapc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c
> index f54c966138b5..33254a979156 100644
> --- a/drivers/soc/mediatek/mtk-devapc.c
> +++ b/drivers/soc/mediatek/mtk-devapc.c
> @@ -109,7 +109,7 @@ static void mask_module_irq(struct mtk_devapc_context *ctx, bool mask)
>    *                       info to VIO_DBGs registers.
>    *
>    */
> -static int devapc_sync_vio_dbg(struct mtk_devapc_context *ctx)
> +static bool devapc_sync_vio_dbg(struct mtk_devapc_context *ctx)
>   {
>   	void __iomem *pd_vio_shift_sta_reg;
>   	void __iomem *pd_vio_shift_sel_reg;