| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <6eebcd0a-810e-4aa5-a16f-523aedf9e50c@oss.qualcomm.com>
Date: Sun, 7 Sep 2025 10:44:57 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
To: kernel test robot <lkp@...el.com>,
Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>,
broonie@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, lgirdwood@...il.com, tiwai@...e.com,
vkoul@...nel.org, srini@...nel.org, yung-chuan.liao@...ux.intel.com,
pierre-louis.bossart@...ux.dev, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org, neil.armstrong@...aro.org,
krzysztof.kozlowski@...aro.org, dmitry.baryshkov@....qualcomm.com,
linux-sound@...r.kernel.org
Subject: Re: [PATCH v3 06/12] ASoC: codecs: wcd: add common helper for wcd
codecs
On 9/6/25 9:23 PM, kernel test robot wrote:
> Hi Srinivas,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on broonie-sound/for-next]
> [also build test ERROR on linus/master v6.17-rc4 next-20250905]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Srinivas-Kandagatla/ASoC-codecs-wcd937x-set-the-comp-soundwire-port-correctly/20250905-234841
> base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> patch link: https://lore.kernel.org/r/20250905154430.12268-7-srinivas.kandagatla%40oss.qualcomm.com
> patch subject: [PATCH v3 06/12] ASoC: codecs: wcd: add common helper for wcd codecs
> config: x86_64-buildonly-randconfig-001-20250907 (https://download.01.org/0day-ci/archive/20250907/202509070437.ko5lmTb9-lkp@intel.com/config)
> compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250907/202509070437.ko5lmTb9-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509070437.ko5lmTb9-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
> sound/soc/codecs/wcd937x.c: In function 'wcd937x_mbhc_micb_ctrl_threshold_mic':
>>> sound/soc/codecs/wcd937x.c:1522:20: error: 'struct wcd937x_priv' has no member named 'micb2_mv'
> 1522 | if (wcd937x->micb2_mv >= WCD_MBHC_THR_HS_MICB_MV)
> | ^~
Thanks for the report,
Sorry about this, I was blindly assuming that wcd937x was part of arm64
defconfig. And there was a typo in the header too,
This is now fixed in v4.
--srini
> sound/soc/codecs/wcd937x.c:1525:61: error: 'struct wcd937x_priv' has no member named 'micb2_mv'
> 1525 | micb_mv = req_en ? WCD_MBHC_THR_HS_MICB_MV : wcd937x->micb2_mv;
> | ^~
> sound/soc/codecs/wcd937x.c: In function 'wcd937x_set_micbias_data':
>>> sound/soc/codecs/wcd937x.c:2432:34: error: 'struct wcd937x_priv' has no member named 'commmon'; did you mean 'common'?
> 2432 | wcd937x->commmon.micb_vout[0]);
> | ^~~~~~~
> | common
> sound/soc/codecs/wcd937x.c:2434:34: error: 'struct wcd937x_priv' has no member named 'commmon'; did you mean 'common'?
> 2434 | wcd937x->commmon.micb_vout[1]);
> | ^~~~~~~
> | common
> sound/soc/codecs/wcd937x.c:2436:34: error: 'struct wcd937x_priv' has no member named 'commmon'; did you mean 'common'?
> 2436 | wcd937x->commmon.micb_vout[2]);
> | ^~~~~~~
> | common
> sound/soc/codecs/wcd937x.c: In function 'wcd937x_probe':
>>> sound/soc/codecs/wcd937x.c:2897:41: error: passing argument 1 of 'wcd_dt_parse_micbias_info' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 2897 | ret = wcd_dt_parse_micbias_info(dev, &wcd937x->common);
> | ^~~
> | |
> | struct device *
> In file included from sound/soc/codecs/wcd937x.c:24:
> sound/soc/codecs/wcd-common.h:25:50: note: expected 'struct wcd_common *' but argument is of type 'struct device *'
> 25 | int wcd_dt_parse_micbias_info(struct wcd_common *common);
> | ~~~~~~~~~~~~~~~~~~~^~~~~~
>>> sound/soc/codecs/wcd937x.c:2897:15: error: too many arguments to function 'wcd_dt_parse_micbias_info'
> 2897 | ret = wcd_dt_parse_micbias_info(dev, &wcd937x->common);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/codecs/wcd-common.h:25:5: note: declared here
> 25 | int wcd_dt_parse_micbias_info(struct wcd_common *common);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/codecs/wcd937x.c:2905:31: error: 'struct wcd937x_priv' has no member named 'micb2_mv'
> 2905 | cfg->micb_mv = wcd937x->micb2_mv;
> | ^~
> cc1: some warnings being treated as errors
> --
> sound/soc/codecs/wcd-common.c: In function 'wcd_dt_parse_micbias_info':
>>> sound/soc/codecs/wcd-common.c:34:41: warning: '-microvolt' directive writing 10 bytes into a region of size between 9 and 19 [-Wformat-overflow=]
> 34 | sprintf(micbias, "qcom,micbias%d-microvolt", micb_num);
> | ^~~~~~~~~~
> In function 'wcd_get_micbias_val',
> inlined from 'wcd_dt_parse_micbias_info' at sound/soc/codecs/wcd-common.c:61:26:
> sound/soc/codecs/wcd-common.c:34:9: note: 'sprintf' output between 24 and 34 bytes into a destination of size 32
> 34 | sprintf(micbias, "qcom,micbias%d-microvolt", micb_num);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
> vim +1522 sound/soc/codecs/wcd937x.c
>
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1508
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1509 static int wcd937x_mbhc_micb_ctrl_threshold_mic(struct snd_soc_component *component,
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1510 int micb_num, bool req_en)
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1511 {
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1512 struct wcd937x_priv *wcd937x = snd_soc_component_get_drvdata(component);
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1513 int micb_mv;
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1514
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1515 if (micb_num != MIC_BIAS_2)
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1516 return -EINVAL;
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1517 /*
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1518 * If device tree micbias level is already above the minimum
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1519 * voltage needed to detect threshold microphone, then do
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1520 * not change the micbias, just return.
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1521 */
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 @1522 if (wcd937x->micb2_mv >= WCD_MBHC_THR_HS_MICB_MV)
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1523 return 0;
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1524
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1525 micb_mv = req_en ? WCD_MBHC_THR_HS_MICB_MV : wcd937x->micb2_mv;
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1526
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1527 return wcd937x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2);
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1528 }
> 9be3ec196da41b Prasad Kumpatla 2024-05-24 1529
>
Powered by blists - more mailing lists