linux-kernel - Re: [PATCH net-next v04 06/14] hinic3: Nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250908032741.1849-1-gongfan1@huawei.com>
Date: Mon, 8 Sep 2025 11:27:40 +0800
From: Fan Gong <gongfan1@...wei.com>
To: <vadim.fedorenko@...ux.dev>
CC: <andrew+netdev@...n.ch>, <christophe.jaillet@...adoo.fr>,
	<corbet@....net>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<gongfan1@...wei.com>, <guoxin09@...wei.com>, <gur.stavi@...wei.com>,
	<helgaas@...nel.org>, <horms@...nel.org>, <kuba@...nel.org>, <lee@...ger.us>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<luosifu@...wei.com>, <luoyang82@...artners.com>, <meny.yossefi@...wei.com>,
	<mpe@...erman.id.au>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<przemyslaw.kitszel@...el.com>, <shenchenyang1@...ilicon.com>,
	<shijing34@...wei.com>, <sumang@...vell.com>, <wulike1@...wei.com>,
	<zhoushuai28@...wei.com>, <zhuyikai1@...artners.com>
Subject: Re: [PATCH net-next v04 06/14] hinic3: Nic_io initialization

On 9/8/2025 1:02 AM, Vadim Fedorenko wrote:

> >   int hinic3_init_hwdev(struct pci_dev *pdev)
> >   {
> >       struct hinic3_pcidev *pci_adapter = pci_get_drvdata(pdev);
> > @@ -451,6 +463,7 @@ int hinic3_init_hwdev(struct pci_dev *pdev)
> >       hwdev->pdev = pci_adapter->pdev;
> >       hwdev->dev = &pci_adapter->pdev->dev;
> >       hwdev->func_state = 0;
> > +    hwdev->dev_id = hinic3_adev_idx_alloc(); 
> 
> Why do you need dev_id? It's not used anywhere in the patchset. The
> commit doesn't explain it neither... 

Thanks for your commit.
This is the code to refine the first patchset of hinic3 driver. In
hinic3_lld.c, we use "hadev->adev.id = hwdev->dev_id;" and dev_id
is temporarily set to default value 0. In this patchset we complete
hwdev's initialization.
I will update this commit message to explain this modification.