linux-kernel - Re: [PATCH v4 3/3] mfd: vortex: implement new driver for Vortex southbridges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250908142429.GC9224@google.com>
Date: Mon, 8 Sep 2025 15:24:29 +0100
From: Lee Jones <lee@...nel.org>
To: Marcos Del Sol Vives <marcos@...a.pet>
Cc: linux-kernel@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Michael Walle <mwalle@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>, linux-gpio@...r.kernel.org,
	linux-pci@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...el.com>,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH v4 3/3] mfd: vortex: implement new driver for Vortex
 southbridges

On Thu, 04 Sep 2025, Marcos Del Sol Vives wrote:

> El 04/09/2025 a las 12:17, Lee Jones escribió:
> >> That GPIO is something required to perform the poweroff sequence, a must
> >> for any machine, while WDT is just a "nice to have".
> >>
> >> Implementing now the WDT just because of a linguistic preference means
> >> delaying something more important in favour of a "nice to have".
> > 
> > You use the word "delaying" here.  What's the rush?
> > 
> > If you only need a GPIO driver, then you don't need the MFD part.
> > 
> 
> I would honestly like that my machines can turn off properly and pretty
> sure others using these platforms would agree on that, as having to yank
> out the power cable is far from ideal.
> 
> Adding WDT would lengthen even further the review process. That ignoring
> I am doing this as a hobby on my spare time and I'd rather spend my
> scarce free time implementing the power off driver than the WDT
> (something I'd do out of completion, I have absolutely no use for a WDT
> in this machine).

Then don't implement it.  Just have the GPIO driver probe on PCI match.

> The reason I am using an MFD is that I was asked to back in v2
> (https://lore.kernel.org/all/aHElavFTptu0q4Kj@smile.fi.intel.com/).
> I'll be CC'ing him.

Andy knows the rules.

> I was told to create a southbridge driver that would match on PCI
> and registered other devices exposed by it as platform drivers.

PCI => Platform is generally decried by Greg and others.

a) With only one device to register, are you sure you need this?
b) If you have more devices, either add them here or use Aux Bus.

> GPIO was the only functionality implemented at the time, and is
> the only functionality implemented right now. So I simply delivered was
> I was asked for.

-- 
Lee Jones [李琼斯]