linux-kernel - Re: [PATCH v2 2/2] hid: intel-thc-hid: intel-quickspi: Add WCL Device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250908034205.1157182-1-even.xu@intel.com>
Date: Mon,  8 Sep 2025 11:42:05 +0800
From: Even Xu <even.xu@...el.com>
To: xinpeng.sun@...el.com
Cc: bentiss@...nel.org,
	jikos@...nel.org,
	linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	srinivas.pandruvada@...ux.intel.com,
	Even Xu <even.xu@...el.com>
Subject: Re: [PATCH v2 2/2] hid: intel-thc-hid: intel-quickspi: Add WCL Device IDs

> From: Xinpeng Sun <xinpeng.sun@...el.com>
> To: jikos@...nel.org, bentiss@...nel.org
> Cc: srinivas.pandruvada@...ux.intel.com, linux-input@...r.kernel.org,
> 	linux-kernel@...r.kernel.org, Xinpeng Sun <xinpeng.sun@...el.com>
> Subject: [PATCH v2 2/2] hid: intel-thc-hid: intel-quickspi: Add WCL Device IDs
> Date: Thu, 28 Aug 2025 10:09:59 +0800	[thread overview]
> Message-ID: <20250828021000.3299377-2-xinpeng.sun@...el.com> (raw)
> In-Reply-To: <20250828021000.3299377-1-xinpeng.sun@...el.com>
> 
> Add THC SPI WildcatLake device IDs.
> 
> Signed-off-by: Xinpeng Sun <xinpeng.sun@...el.com>

LGTM, thanks for the patch!

Reviewed-by: Even Xu <even.xu@...el.com>

> ---
>  drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 2 ++
>  drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> index 5e5f179dd113..84314989dc53 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> @@ -976,6 +976,8 @@ static const struct pci_device_id quickspi_pci_tbl[] = {
>  	{PCI_DEVICE_DATA(INTEL, THC_PTL_H_DEVICE_ID_SPI_PORT2, &ptl), },
>  	{PCI_DEVICE_DATA(INTEL, THC_PTL_U_DEVICE_ID_SPI_PORT1, &ptl), },
>  	{PCI_DEVICE_DATA(INTEL, THC_PTL_U_DEVICE_ID_SPI_PORT2, &ptl), },
> +	{PCI_DEVICE_DATA(INTEL, THC_WCL_DEVICE_ID_SPI_PORT1, &ptl), },
> +	{PCI_DEVICE_DATA(INTEL, THC_WCL_DEVICE_ID_SPI_PORT2, &ptl), },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(pci, quickspi_pci_tbl);
> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
> index 6fdf674b21c5..f3532d866749 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h
> @@ -19,6 +19,8 @@
>  #define PCI_DEVICE_ID_INTEL_THC_PTL_H_DEVICE_ID_SPI_PORT2	0xE34B
>  #define PCI_DEVICE_ID_INTEL_THC_PTL_U_DEVICE_ID_SPI_PORT1	0xE449
>  #define PCI_DEVICE_ID_INTEL_THC_PTL_U_DEVICE_ID_SPI_PORT2	0xE44B
> +#define PCI_DEVICE_ID_INTEL_THC_WCL_DEVICE_ID_SPI_PORT1 	0x4D49
> +#define PCI_DEVICE_ID_INTEL_THC_WCL_DEVICE_ID_SPI_PORT2 	0x4D4B
>  
>  /* HIDSPI special ACPI parameters DSM methods */
>  #define ACPI_QUICKSPI_REVISION_NUM			2
> -- 
> 2.40.1