linux-kernel - Re: [PATCH 1/2] scsi: ufs: Add an enum for ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e090d044-992f-4f4e-b0ca-c310f733b4ed@acm.org>
Date: Mon, 8 Sep 2025 08:27:50 -0700
From: Bart Van Assche <bvanassche@....org>
To: DooHyun Hwang <dh0421.hwang@...sung.com>, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, alim.akhtar@...sung.com, avri.altman@....com,
 James.Bottomley@...senPartnership.com, martin.petersen@...cle.com,
 peter.wang@...iatek.com, manivannan.sadhasivam@...aro.org,
 quic_mnaresh@...cinc.com
Cc: grant.jung@...sung.com, jt77.jang@...sung.com, junwoo80.lee@...sung.com,
 jangsub.yi@...sung.com, sh043.lee@...sung.com, cw9316.lee@...sung.com,
 sh8267.baek@...sung.com, wkon.kim@...sung.com
Subject: Re: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs cmd
 error

On 9/8/25 12:43 AM, DooHyun Hwang wrote:
> Would it be acceptable to add UFS_UIC_SEND, UFS_UIC_COMP,
> and UFS_UIC_ERR at the end of the enum?
> 
> I am aware that UFS_DEV_COMP is currently not used in the code,
> but I am concerned about whether it is appropriate to modify
> or remove existing enum labels.

Please take a look at Documentation/process/stable-api-nonsense.rst.
While the Android GKI kernels have a stable ABI, the upstream kernel
does not promise a stable ABI. Hence, the concerns that apply to GKI
kernels regarding changing the numerical value of enum labels do not
apply to the upstream kernel. It is the responsibility of anyone who
backports an upstream patch to a GKI kernel branch to make sure that
the GKI ABI is not modified.

Thanks,

Bart.