linux-kernel - Re: [PATCH v5 6/7] selftests: prctl: introduce tests for disabling THPs completely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <771871a1-9ee7-472d-b8fd-449565c5ae80@sirena.org.uk>
Date: Mon, 8 Sep 2025 16:38:03 +0100
From: Mark Brown <broonie@...nel.org>
To: Usama Arif <usamaarif642@...il.com>
Cc: Zi Yan <ziy@...dia.com>, Andrew Morton <akpm@...ux-foundation.org>,
	david@...hat.com, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
	corbet@....net, rppt@...nel.org, surenb@...gle.com, mhocko@...e.com,
	hannes@...xchg.org, baohua@...nel.org, shakeel.butt@...ux.dev,
	riel@...riel.com, laoar.shao@...il.com, dev.jain@....com,
	baolin.wang@...ux.alibaba.com, npache@...hat.com,
	lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
	ryan.roberts@....com, vbabka@...e.cz, jannh@...gle.com,
	Arnd Bergmann <arnd@...db.de>, sj@...nel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	kernel-team@...a.com, Aishwarya.TCV@....com
Subject: Re: [PATCH v5 6/7] selftests: prctl: introduce tests for disabling
 THPs completely

On Fri, Sep 05, 2025 at 08:40:25PM +0100, Usama Arif wrote:

> diff --git a/tools/testing/selftests/mm/prctl_thp_disable.c b/tools/testing/selftests/mm/prctl_thp_disable.c
> index 89ed0d7db1c16..0afcdbad94f3d 100644
> --- a/tools/testing/selftests/mm/prctl_thp_disable.c
> +++ b/tools/testing/selftests/mm/prctl_thp_disable.c
> @@ -9,6 +9,7 @@
>  #include <string.h>
>  #include <unistd.h>
>  #include <sys/mman.h>
> +#include <linux/mman.h>
>  #include <sys/prctl.h>
>  #include <sys/wait.h>

> should fix this issue?

That seems to do the right thing for me, I'm slightly nervous about
collisions with glibc in future (it's been an issue in the past when
they're not using our headers) but I guess we can deal with that if it
actually comes up.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)