linux-kernel - Re: [PATCH v3 1/4] dt-bindings: leds: add generic LED consumer documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <COW1cS_CD75b8_MjT5gZA2c8oVf7iAbYPP7RR0TfJwPCqyhpf7LJn8YRjePaJHKnqE4TQZq4UTvmHGlSiv6rVJjdQSmp70FAjg5zkPbEeh0=@vinarskis.com>
Date: Mon, 08 Sep 2025 15:43:22 +0000
From: Aleksandrs Vinarskis <alex@...arskis.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Bjorn Andersson <andersson@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Daniel Thompson <daniel.thompson@...aro.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, Pavel Machek <pavel@...nel.org>, devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, Jacopo Mondi <jacopo@...ndi.org>, Hans de Goede <hansg@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org, Jingoo Han <jingoohan1@...il.com>, dri-devel@...ts.freedesktop.org, Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-media@...r.kernel.org, linux-leds@...r.kernel.org, Jean-Jacques Hiblot <jjhiblot@...phandler.com>, Daniel Thompson <danielt@...nel.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: leds: add generic LED consumer documentation






On Monday, September 8th, 2025 at 16:15, Rob Herring (Arm) <robh@...nel.org> wrote:

> 
> 
> 
> On Mon, 08 Sep 2025 01:18:03 +0200, Aleksandrs Vinarskis wrote:
> 
> > Introduce common generic led consumer binding, where consumer defines
> > led(s) by phandle, as opposed to trigger-source binding where the
> > trigger source is defined in led itself.
> > 
> > Add already used in some schemas 'leds' parameter which expects
> > phandle-array. Additionally, introduce 'led-names' which could be used
> > by consumers to map LED devices to their respective functions.
> > 
> > Signed-off-by: Aleksandrs Vinarskis alex@...arskis.com
> > ---
> > .../devicetree/bindings/leds/leds-consumer.yaml | 89 ++++++++++++++++++++++
> > 1 file changed, 89 insertions(+)
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-consumer.example.dtb: camera@36 (ovti,ov02c10): Unevaluated properties are not allowed ('led-names', 'leds' were unexpected)
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov02e10.yaml#

Rob: this is because the 1st patch that adds `led-consumer.yaml` uses
ov02e10 in its example, while the property is added to
`video-interface-devices.yaml` (which is used by ov02e10 and other
cameras) only in the 2nd patch. As I see it, reversing the order of 1st
and 2nd patch would likewise cause 'error' when 1st patch is checked
without the 2nd one. I don't think that 1st and 2nd patches should be
combined, but if you prefer to do that so the warning goes away - please
let me know.

When running checks on the entire series/last commit, no binding errors
are present.

Alex

> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250908-leds-v3-1-5944dc400668@vinarskis.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in this patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.