linux-kernel - Re: [PATCH v4 4/4] arm64: dts: qcom: monaco-evk: Add sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bbe50f6-5fa3-4685-8f2c-67986c5171ab@oss.qualcomm.com>
Date: Mon, 8 Sep 2025 17:55:55 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Bjorn Andersson <andersson@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Umang Chheda <umang.chheda@....qualcomm.com>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Richard Cochran <richardcochran@...il.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/4] arm64: dts: qcom: monaco-evk: Add sound card

On 9/8/25 4:55 PM, Bjorn Andersson wrote:
> On Sat, Sep 06, 2025 at 10:26:23PM +0300, Dmitry Baryshkov wrote:
>> On Sat, Sep 06, 2025 at 12:53:50AM +0530, Umang Chheda wrote:
>>> From: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>
>>>
>>> Add the sound card for monaco-evk board and verified playback
>>> functionality using the max98357a I2S speaker amplifier and I2S
>>> microphones. The max98357a speaker amplifier is connected via
>>> High-Speed MI2S HS0 interface, while the microphones utilize the
>>> Secondary MI2S interface and also enable required pin controller
>>> gpios for audio.
>>>
>>> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>
>>> Signed-off-by: Umang Chheda <umang.chheda@....qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 52 +++++++++++++++++++++++++
>>>  arch/arm64/boot/dts/qcom/qcs8300.dtsi   | 37 ++++++++++++++++++
>>>  2 files changed, 89 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> index 93e9e5322a39..f3c5d363921e 100644
>>> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> @@ -6,6 +6,7 @@
>>>  /dts-v1/;
>>>
>>>  #include <dt-bindings/gpio/gpio.h>
>>> +#include <dt-bindings/sound/qcom,q6afe.h>
>>>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>
>>>  #include "qcs8300.dtsi"
>>> @@ -24,6 +25,57 @@ aliases {
>>>  	chosen {
>>>  		stdout-path = "serial0:115200n8";
>>>  	};
>>> +
>>> +	dmic: audio-codec-0 {
>>> +		compatible = "dmic-codec";
>>> +		#sound-dai-cells = <0>;
>>> +		num-channels = <1>;
>>> +	};
>>> +
>>> +	max98357a: audio-codec-1 {
>>> +		compatible = "maxim,max98357a";
>>> +		#sound-dai-cells = <0>;
>>> +	};
>>> +
>>> +	sound {
>>> +		compatible = "qcom,qcs8275-sndcard";
>>
>> qcs8300
>>
> 
> If the Monaco EVK actually is QCS8300... But, I presume qcs8275 and
> qcs8300 are identical when it comes to sound?
> 
> @Mohammad, if this is the case can't we just support the
> qcom,monaco-sndcard instead to avoid this confusion?

Commit 34d340d48e59 ("ASoC: qcom: sc8280xp: Add support for QCS8275")

Unless we choose to ignore that compatible and add "monaco", but I don't
think dt maintainers will love that

Konrad