linux-kernel - Re: [PATCH 6/6] mshv: Introduce new hypercall to map stats page for L1VH partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b8dba3e-3ad5-4769-80b1-214c8b1cd3ae@linux.microsoft.com>
Date: Mon, 8 Sep 2025 09:26:13 -0700
From: Easwar Hariharan <easwar.hariharan@...ux.microsoft.com>
To: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
Cc: easwar.hariharan@...ux.microsoft.com, linux-hyperv@...r.kernel.org,
 linux-kernel@...r.kernel.org, kys@...rosoft.com, haiyangz@...rosoft.com,
 wei.liu@...nel.org, mhklinux@...look.com, decui@...rosoft.com,
 paekkaladevi@...ux.microsoft.com,
 Jinank Jain <jinankjain@...ux.microsoft.com>
Subject: Re: [PATCH 6/6] mshv: Introduce new hypercall to map stats page for
 L1VH partitions

On 9/5/2025 4:12 PM, Nuno Das Neves wrote:
> On 9/5/2025 12:50 PM, Easwar Hariharan wrote:
>> On 8/28/2025 5:43 PM, Nuno Das Neves wrote:
>>> From: Jinank Jain <jinankjain@...ux.microsoft.com>
>>>
>>> Introduce HVCALL_MAP_STATS_PAGE2 which provides a map location (GPFN)
>>> to map the stats to. This hypercall is required for L1VH partitions,
>>> depending on the hypervisor version. This uses the same check as the
>>> state page map location; mshv_use_overlay_gpfn().
>>>
>>> Add mshv_map_vp_state_page() helpers to use this new hypercall or the
>>> old one depending on availability.
>>>
>>> For unmapping, the original HVCALL_UNMAP_STATS_PAGE works for both
>>> cases.
>>>
>>> Signed-off-by: Jinank Jain <jinankjain@...ux.microsoft.com>
>>> Signed-off-by: Nuno Das Neves <nunodasneves@...ux.microsoft.com>
>>> ---
>>>  drivers/hv/mshv_root.h         | 10 ++--
>>>  drivers/hv/mshv_root_hv_call.c | 92 ++++++++++++++++++++++++++++++++--
>>>  drivers/hv/mshv_root_main.c    | 25 +++++----
>>>  include/hyperv/hvgdk_mini.h    |  1 +
>>>  include/hyperv/hvhdk_mini.h    |  7 +++
>>>  5 files changed, 115 insertions(+), 20 deletions(-)
>>>

<snip>

>>
>> Shouldn't this be in the previous patch where the other hv_call_map_stat_page() calls were
>> converted, same below?
>>
> The previous patch converts hv_call_(un)map_vp_state_page to hv_(un)map_vp_state_page, i.e.
> "state" not "stats".
> 

Ugh, thanks for the catch. I guess my eyes glazed over a little bit with the diffs.

Thanks,
Easwar (he/him)