linux-kernel - Re: [PATCHv2 net-next 2/2] net: thunder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <002d8e1a-ca2e-41e7-8751-429c2ee728c3@lunn.ch>
Date: Mon, 8 Sep 2025 18:31:29 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Sunil Goutham <sgoutham@...vell.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"moderated list:ARM/CAVIUM THUNDER NETWORK DRIVER" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 net-next 2/2] net: thunder_bgx: use OF loop instead of
 fwnode

On Thu, Sep 04, 2025 at 02:32:28PM -0700, Rosen Penev wrote:
> This is implemented under CONFIG_OF_MDIO, which already assumes an OF
> node.

I'm not sure that is correct.

bgx_probe() -> bgx_init_phy() -> bgx_init_of_phy()

static int bgx_init_phy(struct bgx *bgx)
{
	if (!acpi_disabled)
		return bgx_init_acpi_phy(bgx);

	return bgx_init_of_phy(bgx);
}

There is no check made to see if this is an ACPI node and so
bgx_init_acpi_phy() is called. So it might be an ACPI node is passed
to bgx_init_of_phy().

How have you tested this code? On an ACPI machine, or only a DT
machine?

	Andrew