linux-kernel - Re: [PATCH] net: atlantic: make RX page order tunable via module param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <802c483c-c203-4546-bda5-1337e02dd632@lunn.ch>
Date: Mon, 8 Sep 2025 19:12:13 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Yangyu Chen <cyy@...self.name>
Cc: netdev@...r.kernel.org, Igor Russkikh <irusskikh@...vell.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: atlantic: make RX page order tunable via module
 param

> +static unsigned int rxpageorder = AQ_CFG_RX_PAGEORDER;
> +module_param_named(rxpageorder, rxpageorder, uint, 0644);
> +MODULE_PARM_DESC(rxpageorder, "RX page order");

Sorry, but netdev does not like module params. They are a bad API to
use. Please find a different way to do this.

Also, there is a comment:

	/* Only order-2 is allowed if XDP is enabled */
	if (READ_ONCE(self->xdp_prog)) {

You need to ensure this assumption is not broken.

	Andrew