[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250908175902.214066-1-chiru.cezar.89@gmail.com>
Date: Mon, 8 Sep 2025 20:58:59 +0300
From: Cezar Chiru <chiru.cezar.89@...il.com>
To: andi.shyti@...nel.org,
Markus.Elfring@....de
Cc: linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org,
Cezar Chiru <chiru.cezar.89@...il.com>
Subject: [PATCH v3 0/3] i2c: PCF8584: Fix errors reported by checkpatch.pl
Hello maintainers,
This patch series fixes 18 errors reported by checkpatch.pl on
drivers/i2c/algos/i2c-algo-pcf.c file.
The series v1->v2->v3 is a response to the discussion on the mailing
list with Markus Elfring that had comments on my earlier submisions. First
he suggested to split my initial submission in a patch series. Then he had
some valid points on imperative mood usage in commit messages, wrapping
commit message to 75 columns per line.
Here is a brief summary and Order of patches to be applied:
Patch 1/3: i2c: PCF8584: Fix debug macros defines of if statements
This patch encloses the debug macro defines of if statements in do-while
loops.
Patch 2/3: i2c: PCF8584: Fix do not use assignment in if conditional
This patch takes the assignement from if conditional and moves it by 1 line
up.
Patch 3/3: i2c: PCF8584: Fix space(s) required before or after different
operators
This patch adds space(s) around, before or after some operators
Testing:
*built kernel and modules with I2C_ALGOPCF=m and my 3 patches applied on
top.
*installed kernel and external modules generated by build on my laptop
*rebooted and loaded i2c-algo-pcf.ko with param i2c_debug=2/3/9.
*No success message related to i2c_algo_pcf was seen in dmesg but also no
errors.
*Module loading and unloading successfull.
*No PCF8584 Hardware was available.
Patches 1 and 3 report 4 and 6 warnings when running checkpatch on them.
But the warnings will be fixed in a new patchset that addresses fixing
warnings.
Cezar Chiru (3):
i2c: PCF8584: Fix debug macros defines of if statements
i2c: PCF8584: Fix do not use assignment in if conditional
i2c: PCF8584: Fix space(s) required before or after different operators
drivers/i2c/algos/i2c-algo-pcf.c | 62 ++++++++++++++++++++------------
1 file changed, 39 insertions(+), 23 deletions(-)
--
2.43.0
Powered by blists - more mailing lists