linux-kernel - Re: [PATCH v3 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de6b31ec-7a5a-43a1-b352-2b46055a1a23@gmail.com>
Date: Mon, 8 Sep 2025 08:10:11 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>,
 Jonathan Cameron <jic23@...nel.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Marcelo Schmitt <marcelo.schmitt@...log.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Tobias Sperling <tobias.sperling@...ting.com>,
 Antoniu Miclaus <antoniu.miclaus@...log.com>,
 Trevor Gamblin <tgamblin@...libre.com>, Esteban Blanc <eblanc@...libre.com>,
 Ramona Alexandra Nechita <ramona.nechita@...log.com>,
 Hans de Goede <hansg@...nel.org>, Herve Codina <herve.codina@...tlin.com>,
 Alisa-Dariana Roman <alisadariana@...il.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO

On 07/09/2025 23:55, Andy Shevchenko wrote:
> On Sun, Sep 7, 2025 at 2:42 PM Jonathan Cameron <jic23@...nel.org> wrote:
>> On Fri, 5 Sep 2025 09:42:31 +0300
>> Matti Vaittinen <mazziesaccount@...il.com> wrote:
> 
> ...
> 
>>> +/* ADC channels as named in the data-sheet */
>>> +static const char * const bd79112_chan_names[] = {
>>> +     "AGIO0A", "AGIO1A", "AGIO2A", "AGIO3A", "AGIO4A",       /* 0 - 4 */
>>> +     "AGIO5A", "AGIO6A", "AGIO7A", "AGIO8A", "AGIO9A",       /* 5 - 9 */
>>> +     "AGIO10A", "AGIO11A", "AGIO12A", "AGIO13A", "AGIO14A",  /* 10 - 14 */
>>> +     "AGIO15A", "AGIO0B", "AGIO1B", "AGIO2B", "AGIO3B",      /* 15 - 19 */
>>> +     "AGIO4B", "AGIO5B", "AGIO6B", "AGIO7B", "AGIO8B",       /* 20 - 24 */
>>> +     "AGIO9B", "AGIO10B", "AGIO11B", "AGIO12B", "AGIO13B",   /* 25 - 29 */
>>> +     "AGIO14B", "AGIO15B",                                   /* 30 - 31 */
>>> +};
>>
>>> +     /* Let's assign data-sheet names to channels */
>> Not seeing any value in this comment given the code that follows.
>> Probably drop it
> 
> It was my suggestion. I don't know if you noticed that the amount of> the values is *not* power-of-two and it's harder to find a needed
> value in the list. Moreover, you can read the discussion back and find
> that actually it was a mistake in the list, which can be avoided (or
> chances of which will be minimized) in the first place if we see the
> comments.

I believe Jonathan meant the:
 >>> +/* ADC channels as named in the data-sheet */

not the "index comments". And I kinda agree with him, that's not adding 
too much. I'll drop that as suggested.

Yours,
	-- Matti