linux-kernel - Re: [PATCH] arm64: dts: amlogic: gxbb-odroidc2: remove UHS capability for SD card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29a776da-cd28-46e4-8b64-400f462d8670@baylibre.com>
Date: Mon, 8 Sep 2025 22:15:08 +0200
From: Valerio Setti <vsetti@...libre.com>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: gxbb-odroidc2: remove UHS capability
 for SD card

Thanks a lot for the review!

> The above should be enough.
> 
>>   	max-frequency = <100000000>;
>>   	disable-wp;
>>   
>>   	cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
>>   
>>   	vmmc-supply = <&tflash_vdd>;
>> -	vqmmc-supply = <&tf_io>;
> 
> ... but do not remove that.
> 
> That way the description is complete and the kernel is able to verify
> the regulator is properly configured.

Thanks for the hint! I didn't thought about this while working on it, 
but I tried it today and it worked perfectly.

> It is also easier for a bootloader to alter DT to add the UHS modes back
> (it is safe to do so if booting from another device that SD, such as
> eMMC)

This sounds like a nice improvement as well.

-- 
Valerio