linux-kernel - Re: [PATCH v2 02/18] mm/ksw: add ksw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aL5wjbUYp3_qObzt@mdev>
Date: Mon, 8 Sep 2025 13:58:37 +0800
From: Jinchao Wang <wangjinchao600@...il.com>
To: Mike Rapoport <rppt@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	"Naveen N . Rao" <naveen@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	David Hildenbrand <david@...hat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Michal Hocko <mhocko@...e.com>, linux-perf-users@...r.kernel.org,
	linux-mm@...ck.org, linux-trace-kernel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/18] mm/ksw: add ksw_config struct and parser

On Thu, Sep 04, 2025 at 10:47:07AM +0300, Mike Rapoport wrote:
> On Thu, Sep 04, 2025 at 08:20:59AM +0800, Jinchao Wang wrote:
> > Add struct ksw_config and ksw_parse_config() to parse user string.
> > 
> > Update `Makefile` to pass compilation.
> > 
> > Signed-off-by: Jinchao Wang <wangjinchao600@...il.com>
> > ---
> >  mm/kstackwatch/Makefile      |  2 ++
> >  mm/kstackwatch/kernel.c      | 70 +++++++++++++++++++++++++++++++++++-
> >  mm/kstackwatch/kstackwatch.h | 34 ++++++++++++++++++
> >  3 files changed, 105 insertions(+), 1 deletion(-)
> > 
> > diff --git a/mm/kstackwatch/Makefile b/mm/kstackwatch/Makefile
> > index 84a46cb9a766..d422f0e114dd 100644
> > --- a/mm/kstackwatch/Makefile
> > +++ b/mm/kstackwatch/Makefile
> > @@ -1,2 +1,4 @@
> >  obj-$(CONFIG_KSTACK_WATCH)	+= kstackwatch.o
> >  kstackwatch-y := kernel.o stack.o watch.o
> > +
> > +CFLAGS_kernel.o := -Wno-error=unused-function
> 
> Can't you just add the function along with the code that uses it?
Thanks for the feedback.

The function ksw_parse_config is called deeply in a later patch, so the
'error: ununsed function' would persist even if I added the caller now.

To keep this patch clean for review, I only include functions that form
a self-contained unit.

I will add a TODO comment to indicate that the CFLAGS addition is
temporary for this patch only and will be removed in a follow-up patch.
> 
> -- 
> Sincerely yours,
> Mike.