linux-kernel - Re: [PATCH v1 0/2] HiSilicon STB PCIe host use bulk API for clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mcfkxjbyee4y6fh6akypyubovb45xusvkamh5cltc4j6e7cdrm@gekavh6ybr6c>
Date: Mon, 8 Sep 2025 12:06:46 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Anand Moon <linux.amoon@...il.com>
Cc: Shawn Guo <shawn.guo@...aro.org>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Philipp Zabel <p.zabel@...gutronix.de>, 
	"open list:PCIE DRIVER FOR HISILICON STB" <linux-pci@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 0/2] HiSilicon STB PCIe host use bulk API for clock

On Tue, Aug 26, 2025 at 05:12:39PM GMT, Anand Moon wrote:
> Simplify the code using the clk_bulk*() and reset_control_bulk() APIs
> 

We need either an Ack from Shawn or the Tested-by tag from anyone having access
to the HiSTB boards.

Also, as others explained, you need to mention the potential order reversing
while switching to these APIs as they may break the driver.

- Mani

> Thanks
> -Anand
> 
> Anand Moon (2):
>   PCI: dwc: histb: Simplify clock handling by using clk_bulk*()
>     functions
>   PCI: dwc: histb: Simplify reset control handling by using
>     reset_control_bulk*() function
> 
>  drivers/pci/controller/dwc/pcie-histb.c | 119 +++++++-----------------
>  1 file changed, 35 insertions(+), 84 deletions(-)
> 
> 
> base-commit: fab1beda7597fac1cecc01707d55eadb6bbe773c
> -- 
> 2.50.1
> 

-- 
மணிவண்ணன் சதாசிவம்