linux-kernel - Re: [PATCH v1 3/3] cpufreq: intel_pstate: Adjust frequency percentage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250908011259.2047702-1-zhangzihuan@kylinos.cn>
Date: Mon,  8 Sep 2025 09:12:59 +0800
From: Zihuan Zhang <zhangzihuan@...inos.cn>
To: rafael@...nel.org
Cc: jonathan.cameron@...wei.com,
	linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org,
	srinivas.pandruvada@...ux.intel.com,
	viresh.kumar@...aro.org,
	zhangzihuan@...inos.cn
Subject: Re: [PATCH v1 3/3] cpufreq: intel_pstate: Adjust frequency percentage

> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/cpufreq/intel_pstate.c |    8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1696,8 +1696,8 @@ unlock_driver:
>  static void update_cpu_qos_request(int cpunum, enum freq_qos_req_type type)
>  {
>  	struct cpudata *cpu = all_cpu_data[cpunum];
> +	unsigned int freq = cpu->pstate.turbo_freq;
>  	struct freq_qos_request *req;
> -	unsigned int freq, perf_pct;
>  
>  	struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpunum);
>  	if (!policy)
> @@ -1711,14 +1711,12 @@ static void update_cpu_qos_request(int c
>  		intel_pstate_get_hwp_cap(cpu);
>  
>  	if (type == FREQ_QOS_MIN) {
> -		perf_pct = global.min_perf_pct;
> +		freq = DIV_ROUND_UP(freq * global.min_perf_pct, 100);
>  	} else {
>  		req++;
> -		perf_pct = global.max_perf_pct;
> +		freq = (freq * global.max_perf_pct) / 100;
>  	}
>  
> -	freq = DIV_ROUND_UP(cpu->pstate.turbo_freq * perf_pct, 100);
> -
>  	if (freq_qos_update_request(req, freq) < 0)
>  		pr_warn("Failed to update freq constraint: CPU%d\n", cpunum);
>  }

Acked-by: Zihuan Zhang <zhangzihuan@...inos.cn>