linux-kernel - Re: [PATCH 00/11] PCI: Keystone: Enable loadable module support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5825153e-833b-4aed-bbd5-e0f58e922aa0@ti.com>
Date: Mon, 8 Sep 2025 12:43:23 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Manivannan Sadhasivam <mani@...nel.org>
CC: Siddharth Vadapalli <s-vadapalli@...com>, <lpieralisi@...nel.org>,
        <kwilczynski@...nel.org>, <robh@...nel.org>, <bhelgaas@...gle.com>,
        <jingoohan1@...il.com>, <fan.ni@...sung.com>,
        <quic_wenbyao@...cinc.com>, <namcao@...utronix.de>,
        <mayank.rana@....qualcomm.com>, <thippeswamy.havalige@....com>,
        <quic_schintav@...cinc.com>, <shradha.t@...sung.com>,
        <inochiama@...il.com>, <cassel@...nel.org>, <kishon@...nel.org>,
        <18255117159@....com>, <rongqianfeng@...o.com>, <jirislaby@...nel.org>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <srk@...com>
Subject: Re: [PATCH 00/11] PCI: Keystone: Enable loadable module support

On Mon, Sep 08, 2025 at 09:09:08AM +0530, Manivannan Sadhasivam wrote:
> On Wed, Sep 03, 2025 at 06:14:41PM GMT, Siddharth Vadapalli wrote:
> > Hello,
> > 
> > This series enables support for the 'pci-keystone.c' driver to be built
> > as a loadable module. The motivation for the series is that PCIe is not
> > a necessity for booting Linux due to which the 'pci-keystone.c' driver
> > does not need to be built-in.
> > 
> 
> There are concerns from the irqchip maintainers that unloading an irqchip
> controller is a bad idea. We had a lot of previous discussions on this topic.

Ok, I wasn't aware of this. Thank you for pointing this out.

> 
> But I would certainly welcome the idea of building a controller driver as a
> module (tristate) and prevent unloading it during runtime (by keeping it as
> builtin_platform_driver).

I will update the series to retain 'builtin_platform_driver' while
enabling tristate support. Since the intent of the series is primarily
to convert the driver to support being built as a loadable module, and
unloading it is only a secondary requirement which is optional, I agree
with your suggestion.

> 
> > Series is based on linux-next tagged next-20250903.
> > 
> 
> No need to base your patches on top of linux-next. Either do it on top of -rc1
> or pci/next.

I will keep this in mind when I post the v2 series.

Thank you for your feedback.

Regards,
Siddharth.