linux-kernel - Re: [PATCH] firmware: firmware: meson-sm: fix compile-test default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aL6WVp10hET2-fql@hovoldconsulting.com>
Date: Mon, 8 Sep 2025 10:39:50 +0200
From: Johan Hovold <johan@...nel.org>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Kevin Hilman <khilman@...libre.com>,
	Jerome Brunet <jbrunet@...libre.com>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
	Carlo Caione <ccaione@...libre.com>,
	linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: firmware: meson-sm: fix compile-test default

Hi Neil,

On Mon, Jul 28, 2025 at 05:42:00PM +0200, Neil Armstrong wrote:
> On 25/07/2025 09:54, Johan Hovold wrote:
> > Enabling compile testing should not enable every individual driver (we
> > have "allyesconfig" for that).
> > 
> > Fixes: 4a434abc40d2 ("firmware: meson-sm: enable build as module")
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---
> >   drivers/firmware/meson/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/firmware/meson/Kconfig b/drivers/firmware/meson/Kconfig
> > index f2fdd3756648..179f5d46d8dd 100644
> > --- a/drivers/firmware/meson/Kconfig
> > +++ b/drivers/firmware/meson/Kconfig
> > @@ -5,7 +5,7 @@
> >   config MESON_SM
> >   	tristate "Amlogic Secure Monitor driver"
> >   	depends on ARCH_MESON || COMPILE_TEST
> > -	default y
> > +	default ARCH_MESON
> >   	depends on ARM64_4K_PAGES
> >   	help
> >   	  Say y here to enable the Amlogic secure monitor driver
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>

Could you pick this one up for 6.18 as well?

I noticed that there's a duplicate "firmware: " in Subject, perhaps you
can fix that up when applying?

Johan