| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250908090341.762049-4-jfalempe@redhat.com>
Date: Mon, 8 Sep 2025 11:00:31 +0200
From: Jocelyn Falempe <jfalempe@...hat.com>
To: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>,
Jocelyn Falempe <jfalempe@...hat.com>,
Javier Martinez Canillas <javierm@...hat.com>,
linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: [PATCH v2 3/3] drm/panic: Add a drm_panic/draw_test in debugfs
This adds a new drm_panic/draw_test file in debugfs.
This file allows to test the panic screen rendering at different
resolution and pixel format.
It's useful only for kernel developers that want to create or
customize a panic screen.
If you want to check the result at 1024x768 using XRGB8888:
cd /sys/kernel/debug/drm_panic/
exec 3<> draw_test
echo 1024x768:XR24 >&3
cat <&3 > ~/panic_screen.raw
exec 3<&-
Signed-off-by: Jocelyn Falempe <jfalempe@...hat.com>
---
v2:
* Use debugfs instead of sending the framebuffer through the kunit logs. (Thomas Zimmermann).
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/drm_panic.c | 117 ++++++++++++++++++++++++++++++++++++
2 files changed, 119 insertions(+)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index f7ea8e895c0c..0d3146070d9c 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -83,6 +83,8 @@ config DRM_PANIC_DEBUG
Add dri/[device]/drm_panic_plane_x in the kernel debugfs, to force the
panic handler to write the panic message to this plane scanout buffer.
This is unsafe and should not be enabled on a production build.
+ Also adds a drm_panic/draw_test file in debugfs, to easily test the
+ panic screen rendering.
If in doubt, say "N".
config DRM_PANIC_SCREEN
diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c
index d89812ff1935..0c01d6067eab 100644
--- a/drivers/gpu/drm/drm_panic.c
+++ b/drivers/gpu/drm/drm_panic.c
@@ -873,6 +873,7 @@ static void drm_panic(struct kmsg_dumper *dumper, struct kmsg_dump_detail *detai
*/
#ifdef CONFIG_DRM_PANIC_DEBUG
#include <linux/debugfs.h>
+#include <linux/vmalloc.h>
static ssize_t debugfs_trigger_write(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos)
@@ -901,8 +902,122 @@ static void debugfs_register_plane(struct drm_plane *plane, int index)
debugfs_create_file(fname, 0200, plane->dev->debugfs_root,
plane, &dbg_drm_panic_ops);
}
+
+/*
+ * Draw test interface
+ * This can be used to check the panic screen at any resolution/pixel format.
+ * The framebuffer memory is freed when the file is closed, so use this sh
+ * script to write the parameters and read the result without closing the file.
+ * cd /sys/kernel/debug/drm_panic/
+ * exec 3<> draw_test
+ * echo 1024x768:XR24 >&3
+ * cat <&3 > ~/panic_screen.raw
+ * exec 3<&-
+ */
+static ssize_t debugfs_drawtest_write(struct file *file, const char __user *user_buf,
+ size_t count, loff_t *ppos)
+{
+ struct drm_scanout_buffer *sb = (struct drm_scanout_buffer *) file->private_data;
+ size_t fb_size;
+ void *fb;
+ char buf[64];
+ int width;
+ int height;
+ char cc1, cc2, cc3, cc4;
+ u32 drm_format;
+
+ if (count >= sizeof(buf))
+ return -EINVAL;
+
+ if (copy_from_user(buf, user_buf, count))
+ return -EFAULT;
+
+ if (sscanf(buf, "%dx%d:%c%c%c%c", &width, &height, &cc1, &cc2, &cc3, &cc4) != 6) {
+ pr_err("Invalid format. Expected: <width>x<height>:<fourcc>\n");
+ return -EINVAL;
+ }
+
+ drm_format = fourcc_code(cc1, cc2, cc3, cc4);
+ sb->format = drm_format_info(drm_format);
+ if (!sb->format)
+ return -EINVAL;
+
+ drm_panic_set_description("Test drawing from debugfs");
+
+ sb->width = width;
+ sb->height = height;
+ sb->pitch[0] = width * sb->format->cpp[0];
+
+ if (sb->map[0].vaddr)
+ vfree(sb->map[0].vaddr);
+
+ fb_size = height * sb->pitch[0];
+ fb = vmalloc(fb_size);
+ iosys_map_set_vaddr(&sb->map[0], fb);
+
+ draw_panic_dispatch(sb);
+
+ drm_panic_clear_description();
+ return count;
+}
+
+static ssize_t debugfs_drawtest_read(struct file *file, char __user *user_buf,
+ size_t count, loff_t *ppos)
+{
+ struct drm_scanout_buffer *sb = (struct drm_scanout_buffer *) file->private_data;
+ int fb_size = sb->height * sb->pitch[0];
+
+ if (!sb->map[0].vaddr)
+ return 0;
+ return simple_read_from_buffer(user_buf, count, ppos, sb->map[0].vaddr, fb_size);
+}
+
+static int debugfs_drawtest_open(struct inode *inode, struct file *file)
+{
+ struct drm_scanout_buffer *sb = kzalloc(sizeof(*sb), GFP_KERNEL);
+
+ if (!sb)
+ return -ENOMEM;
+
+ file->private_data = sb;
+ return 0;
+}
+
+static int debugfs_drawtest_release(struct inode *inode, struct file *file)
+{
+ struct drm_scanout_buffer *sb = (struct drm_scanout_buffer *) file->private_data;
+
+ vfree(sb->map[0].vaddr);
+ kfree(sb);
+ return 0;
+}
+
+static const struct file_operations dbg_drm_panic_test_ops = {
+ .owner = THIS_MODULE,
+ .write = debugfs_drawtest_write,
+ .read = debugfs_drawtest_read,
+ .open = debugfs_drawtest_open,
+ .release = debugfs_drawtest_release,
+};
+
+static struct dentry *drm_panic_debugfs_dir;
+
+static void debugfs_register_drawtest(void)
+{
+ drm_panic_debugfs_dir = debugfs_create_dir("drm_panic", NULL);
+ debugfs_create_file("draw_test", 0600, drm_panic_debugfs_dir,
+ NULL, &dbg_drm_panic_test_ops);
+}
+
+static void debugfs_unregister_drawtest(void)
+{
+ debugfs_remove(drm_panic_debugfs_dir);
+}
+
#else
static void debugfs_register_plane(struct drm_plane *plane, int index) {}
+static void debugfs_register_drawtest(void) {}
+static void debugfs_unregister_drawtest(void) {}
#endif /* CONFIG_DRM_PANIC_DEBUG */
/**
@@ -977,6 +1092,7 @@ void drm_panic_unregister(struct drm_device *dev)
void __init drm_panic_init(void)
{
drm_panic_qr_init();
+ debugfs_register_drawtest();
}
/**
@@ -985,6 +1101,7 @@ void __init drm_panic_init(void)
void drm_panic_exit(void)
{
drm_panic_qr_exit();
+ debugfs_unregister_drawtest();
}
#ifdef CONFIG_DRM_KUNIT_TEST
--
2.51.0
Powered by blists - more mailing lists