[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <34f0689a-bfac-4363-a35b-069ae88f0dde@quicinc.com>
Date: Mon, 8 Sep 2025 17:29:06 +0800
From: Baochen Qiang <quic_bqiang@...cinc.com>
To: Miaoqing Pan <miaoqing.pan@....qualcomm.com>, <jjohnson@...nel.org>
CC: <ath12k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH ath-current] wifi: ath12k: fix WMI TLV header misalignment
On 9/8/2025 9:51 AM, Miaoqing Pan wrote:
> When buf_len is not 4-byte aligned in ath12k_wmi_mgmt_send(), the
> firmware asserts and triggers a recovery. The following error
> messages are observed:
>
> ath12k_pci 0004:01:00.0: failed to submit WMI_MGMT_TX_SEND_CMDID cmd
> ath12k_pci 0004:01:00.0: failed to send mgmt frame: -108
> ath12k_pci 0004:01:00.0: failed to tx mgmt frame, vdev_id 0 :-108
> ath12k_pci 0004:01:00.0: waiting recovery start...
>
> This issue was observed when running 'iw wlanx set power_save off/on'
> in MLO station mode, which triggers the sending of an SMPS action frame
> with a length of 27 bytes to the AP. To resolve the misalignment, use
> buf_len_aligned instead of buf_len when constructing the WMI TLV header.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.IOE_HMT.1.1-00011-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Signed-off-by: Miaoqing Pan <miaoqing.pan@....qualcomm.com>
> ---
> drivers/net/wireless/ath/ath12k/wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c
> index 742ffeb48bce..29dadedefdd2 100644
> --- a/drivers/net/wireless/ath/ath12k/wmi.c
> +++ b/drivers/net/wireless/ath/ath12k/wmi.c
> @@ -843,7 +843,7 @@ int ath12k_wmi_mgmt_send(struct ath12k_link_vif *arvif, u32 buf_id,
> cmd->tx_params_valid = 0;
>
> frame_tlv = (struct wmi_tlv *)(skb->data + sizeof(*cmd));
> - frame_tlv->header = ath12k_wmi_tlv_hdr(WMI_TAG_ARRAY_BYTE, buf_len);
> + frame_tlv->header = ath12k_wmi_tlv_hdr(WMI_TAG_ARRAY_BYTE, buf_len_aligned);
>
> memcpy(frame_tlv->value, frame->data, buf_len);
>
>
> base-commit: 27893dd6341b929f87d45fc4d65c5778179319dd
Reviewed-by: Baochen Qiang <baochen.qiang@....qualcomm.com>
Powered by blists - more mailing lists