linux-kernel - Re: [PATCH] m68k: make HPDCA and HPAPCI bools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVXcm=6HmHYfkDF--jTKu-o7jWO=T6EuzeedhEvU3An_A@mail.gmail.com>
Date: Mon, 8 Sep 2025 11:47:48 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-m68k@...ts.linux-m68k.org
Subject: Re: [PATCH] m68k: make HPDCA and HPAPCI bools

Hi Jiri,

On Fri, 22 Aug 2025 at 12:42, Jiri Slaby (SUSE) <jirislaby@...nel.org> wrote:
> The only user -- 8250_hp300 -- tests for CONFIG_HPDCA and CONFIG_HPAPCI.
> It does not test for *_MODULE variants. That means that if someone sets
> the configs to =m, the code is not compiled at all.
>
> There is actually no point having these as tristate. Switch them to
> bool.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>

Thanks for your patch!

> --- a/arch/m68k/Kconfig.devices
> +++ b/arch/m68k/Kconfig.devices
> @@ -105,14 +105,14 @@ config AMIGA_BUILTIN_SERIAL
>           To compile this driver as a module, choose M here.
>
>  config HPDCA
> -       tristate "HP DCA serial support"
> +       bool "HP DCA serial support"
>         depends on DIO && SERIAL_8250
>         help
>           If you want to use the internal "DCA" serial ports on an HP300
>           machine, say Y here.
>
>  config HPAPCI
> -       tristate "HP APCI serial support"
> +       bool "HP APCI serial support"
>         depends on HP300 && SERIAL_8250
>         help
>           If you want to use the internal "APCI" serial ports on an HP400

This still causes a warning if SERIAL_8250 and HP300 are enabled,
but none of HPDCA and HPAPCI are enabled:

    drivers/tty/serial/8250/8250_hp300.c:24:2: warning: #warning
CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI
defined, are you sure? [-Wcpp]
       24 | #warning CONFIG_SERIAL_8250 defined but neither
CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
          |  ^~~~~~~

I have sent and alternativ\e fix.

[1] "[PATCH 0/2] tty: serial: 8250: Rework HP300 serial Kconfig logic"
    https://lore.kernel.org/cover.1757323858.git.geert@linux-m68k.org

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds