linux-kernel - Re:[PATCH v2] null_blk: Fix the description of the cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2baa9d5f.86c7.19928c331e3.Coremail.zhanggenjian@126.com>
Date: Mon, 8 Sep 2025 17:58:24 +0800 (CST)
From: "genjian zhang" <zhanggenjian@....com>
To: axboe@...nel.dk, dlemoal@...nel.org, shinichiro.kawasaki@....com,
	johannes.thumshirn@....com, kch@...dia.com, zhengqixing@...wei.com,
	willy@...radead.org, namcao@...utronix.de, vincent.fu@...sung.com
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Genjian Zhang" <zhanggenjian@...inos.cn>, zhanggenjian@....com
Subject: Re:[PATCH v2] null_blk: Fix the description of the cache_size
 module argument

At 2025-08-15 17:07:32, "Genjian" <zhanggenjian@....com> wrote:
>From: Genjian Zhang <zhanggenjian@...inos.cn>
>
>When executing modinfo null_blk, there is an error in the description
>of module parameter mbps, and the output information of cache_size is
>incomplete.The output of modinfo before and after applying this patch
>is as follows:
>
>Before:
>[...]
>parm:           cache_size:ulong
>[...]
>parm:           mbps:Cache size in MiB for memory-backed device.
>		Default: 0 (none) (uint)
>[...]
>
>After:
>[...]
>parm:           cache_size:Cache size in MiB for memory-backed device.
>		Default: 0 (none) (ulong)
>[...]
>parm:           mbps:Limit maximum bandwidth (in MiB/s).
>		Default: 0 (no limit) (uint)
>[...]
>
>Fixes: 058efe000b31 ("null_blk: add module parameters for 4 options")
>Signed-off-by: Genjian Zhang <zhanggenjian@...inos.cn>
>Reviewed-by: Damien Le Moal <dlemoal@...nel.org>
>---
> drivers/block/null_blk/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
>index 91642c9a3b29..f982027e8c85 100644
>--- a/drivers/block/null_blk/main.c
>+++ b/drivers/block/null_blk/main.c
>@@ -223,7 +223,7 @@ MODULE_PARM_DESC(discard, "Support discard operations (requires memory-backed nu
> 
> static unsigned long g_cache_size;
> module_param_named(cache_size, g_cache_size, ulong, 0444);
>-MODULE_PARM_DESC(mbps, "Cache size in MiB for memory-backed device. Default: 0 (none)");
>+MODULE_PARM_DESC(cache_size, "Cache size in MiB for memory-backed device. Default: 0 (none)");
> 
> static bool g_fua = true;
> module_param_named(fua, g_fua, bool, 0444);
>-- 
>2.25.1

Changes in v2:
 - Adjusted the patch title.
 - Removed redundant blank lines.
 - Link to v1: https://lore.kernel.org/all/30445c6a.6920.198acef8f24.Coremail.zhanggenjian@126.com/

Gentle ping.

Thanks
-Genjian