linux-kernel - Re: [PATCH v2 1/2] i2c: qcom-geni: add OPP table support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99c42878-2b77-4ca1-8fe5-8d51ead618cf@quicinc.com>
Date: Mon, 8 Sep 2025 15:56:52 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Andi Shyti <andi.shyti@...nel.org>
CC: <andersson@...nel.org>, <konradybcio@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <quic_msavaliy@...cinc.com>, <quic_vdadhani@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>,
        <kathiravan.thirumoorthy@....qualcomm.com>
Subject: Re: [PATCH v2 1/2] i2c: qcom-geni: add OPP table support



On 9/5/2025 3:57 AM, Andi Shyti wrote:
>> @@ -814,6 +817,24 @@ static int geni_i2c_probe(struct platform_device *pdev)
>>  		gi2c->clk_freq_out = I2C_MAX_STANDARD_MODE_FREQ;
>>  	}
>>  
>> +	ret = devm_pm_opp_set_clkname(&pdev->dev, "se");
> 
> /&pdev->dev/dev/
> 

Hi Andi,

Okay, sure. I will update in the next version.

>> +	if (ret)
>> +		return ret;
>> +
>> +	/* OPP table is optional */
>> +	ret = devm_pm_opp_of_add_table(dev);
>> +	if (!ret) {
>> +		opp = dev_pm_opp_find_freq_floor(dev, &freq);
>> +		if (IS_ERR(opp))
>> +			return dev_err_probe(dev, PTR_ERR(opp), "failed to find the frequency\n");
>> +		dev_pm_opp_put(opp);
>> +		ret = dev_pm_opp_set_rate(dev, freq);
>> +		if (ret)
>> +			return dev_err_probe(dev, ret, "failed to set the rate=%ld\n", freq);
> 
> %lu
> 

Okay, sure. I will update in the next version.

Thanks & Regards,
Manikanta.