linux-kernel - Re: [PATCH v4 5/6] firmware: arm_scmi: imx: Support getting syslog of MISC protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250908-sparkling-owl-of-judgment-f17eeb@sudeepholla>
Date: Mon, 8 Sep 2025 12:04:12 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Peng Fan <peng.fan@....com>
Cc: Cristian Marussi <cristian.marussi@....com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sudeep Holla <sudeep.holla@....com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, <arm-scmi@...r.kernel.org>,
	<imx@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 5/6] firmware: arm_scmi: imx: Support getting syslog
 of MISC protocol

On Thu, Sep 04, 2025 at 06:40:46PM +0800, Peng Fan wrote:
> MISC protocol supports getting system log regarding system sleep latency
> ,wakeup interrupt and etc. Add the API for user to retrieve the
> information from SM.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c    | 83 ++++++++++++++++++++++
>  include/linux/scmi_imx_protocol.h                  | 23 ++++++
>  2 files changed, 106 insertions(+)
> 

[...]

> diff --git a/include/linux/scmi_imx_protocol.h b/include/linux/scmi_imx_protocol.h
> index 27bd372cbfb142b6acb0b1cf4b82f061529d0d45..ed78660d2f51c554e782b2f665e5bc5046678fd1 100644
> --- a/include/linux/scmi_imx_protocol.h
> +++ b/include/linux/scmi_imx_protocol.h
> @@ -52,6 +52,27 @@ struct scmi_imx_misc_ctrl_notify_report {
>  	unsigned int		flags;
>  };
>  
> +/*
> + * For more detailed information, need check i.MX SM firmware file:
> + * devices/{SOC}/sm/dev_sm_system.h
> + */
> +struct scmi_imx_misc_sys_sleep_rec {
> +	u32 sleepentryusec;	/* System sleep entry latency */
> +	u32 sleepexitusec;	/* System sleep exit latency */
> +	u32 sleepcnt;		/* System sleep counter */
> +	u32 wakesource;		/* IRQ/exception causing system wake */
> +	u32 mixpwrstat;		/* MIX power status */
> +	u32 mempwrstat;		/* MEM power status */
> +	u32 pllpwrstat;		/* PLL power status */
> +	u32 syssleepmode;	/* System sleep mode */
> +	u32 syssleepflags;	/* System sleep flags */
> +};
> +

Much better now. But I am still thinking if this must go to the document to
make sure it remains ABI and firmware can't reorder the as we might have no
way to deal with that. That's the reason I was asking for raw dump so that
you need not put all these details in the spec/document.

> +struct scmi_imx_misc_syslog {
> +	struct scmi_imx_misc_sys_sleep_rec syssleeprecord;
> +	u32 deverrlog; /* device err log: timers, clocks, console and etc */

This is open ended, please add this to the document and make it more precise.

-- 
Regards,
Sudeep