linux-kernel - Re: [PATCH v1 2/2] This patch adds a new DRM bridge driver for the Lontium LT9611C chip.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a38fac371861f8651079d56f703826651f1568e1@intel.com>
Date: Mon, 08 Sep 2025 14:07:38 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: syyang <syyang@...tium.com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andrzej.hajda@...el.com, neil.armstrong@...aro.org,
 rfoss@...nel.org
Cc: Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, devicetree@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 yangsunyun1993@...il.com, syyang <syyang@...tium.com>
Subject: Re: [PATCH v1 2/2] This patch adds a new DRM bridge driver for the
 Lontium LT9611C chip.

On Wed, 03 Sep 2025, syyang <syyang@...tium.com> wrote:
> +static int i2c_write_byte(struct lt9611c *lt9611c, u8 reg, u8 val)

> +static int i2c_read_byte(struct lt9611c *lt9611c, u8 reg, u8 *val)

> +static int i2c_read_write_flow(struct lt9611c *lt9611c, u8 *params,
> +			       unsigned int param_count, u8 *return_buffer,
> +			       unsigned int return_count)

include/linux/i2c.h provides a plethora of i2c_ prefixed functions and
types. I think it's bad practice to reuse the prefix of a very common
kernel interface, even if in static functions.

You might get collisions later, but the reader of the code is mislead to
believe this is something in i2c.h.

BR,
Jani.

-- 
Jani Nikula, Intel