linux-kernel - [PATCH -next] ndtest: Fix incorrect handling for return value of device_create_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250908122331.1315530-1-linyujun809@h-partners.com>
Date: Mon, 8 Sep 2025 20:23:31 +0800
From: Lin Yujun <linyujun809@...artners.com>
To: <dan.j.williams@...el.com>, <vishal.l.verma@...el.com>,
	<dave.jiang@...el.com>, <ira.weiny@...el.com>, <linyujun809@...artners.com>,
	<santosh@...six.org>
CC: <nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: [PATCH -next] ndtest: Fix incorrect handling for return value of device_create_with_groups.

The return value of device_create_with_groups will not
be an null pointer, use IS_ERR() to fix incorrect handling
return value of device_create_with_groups.

Fixes: 9399ab61ad82 ("ndtest: Add dimms to the two buses")
Signed-off-by: Lin Yujun <linyujun809@...artners.com>
---
 tools/testing/nvdimm/test/ndtest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c
index 68a064ce598c..7d722f2f7d62 100644
--- a/tools/testing/nvdimm/test/ndtest.c
+++ b/tools/testing/nvdimm/test/ndtest.c
@@ -745,11 +745,11 @@ static int ndtest_dimm_register(struct ndtest_priv *priv,
 
 	dimm->dev = device_create_with_groups(&ndtest_dimm_class,
 					     &priv->pdev.dev,
 					     0, dimm, dimm_attribute_groups,
 					     "test_dimm%d", id);
-	if (!dimm->dev) {
+	if (IS_ERR(dimm->dev)) {
 		pr_err("Could not create dimm device attributes\n");
 		return -ENOMEM;
 	}
 
 	return 0;
-- 
2.34.1