linux-kernel - Re: [External] : Re: [PATCH] KVM: arm64: vgic: fix incorrect spinlock API usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f618abc2-666c-4455-8a69-62669d367333@oracle.com>
Date: Mon, 8 Sep 2025 18:36:45 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Marc Zyngier <maz@...nel.org>
Cc: jintack@...columbia.edu, christoffer.dall@....com, oliver.upton@...ux.dev,
        joey.gouly@....com, suzuki.poulose@....com, yuzenghui@...wei.com,
        catalin.marinas@....com, will@...nel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [External] : Re: [PATCH] KVM: arm64: vgic: fix incorrect spinlock
 API usage



On 9/8/2025 1:46 PM, Marc Zyngier wrote:
>> diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c
>> index f5148b38120a..c74d6120a12c 100644
>> --- a/arch/arm64/kvm/vgic/vgic.c
>> +++ b/arch/arm64/kvm/vgic/vgic.c
>> @@ -818,7 +818,7 @@ static void vgic_flush_lr_state(struct kvm_vcpu *vcpu)
>>   		 * the AP list has been sorted already.
>>   		 */
>>   		if (multi_sgi && irq->priority > prio) {
>> -			_raw_spin_unlock(&irq->irq_lock);
>> +			raw_spin_unlock(&irq->irq_lock);
>>   			break;
>>   		}
>>   
> With the above fixed:
> 
> Acked-by: Marc Zyngier<maz@...nel.org>


Thanks Marc, I will send v2 with your suggestions.

Thanks,
Alok